Re: [PATCH] ob-ditaa.el: custom var name, ditaa executable, SVG output, and chararacter encoding

[Ihor Radchenko <yantar92@posteo.net>]

Jarmo Hurri <jarmo.hurri@iki.fi> writes:

>>> +	 (png (cdr (assq :png params)))
>>> +	 (svg (cdr (assq :svg params)))
>>>  	 (eps (cdr (assq :eps params)))
>>
>> I am wondering if we could instead deprecate the :png/:eps parameters
>> and instead use the :file extension to decide.
>
> This could be done, but I do not see much harm in providing an
> override. Note that the file extension is used by default.
>
> So, your choice: is it
> a) file extension only
> b) file extension with possibility to override with parameters?

AFAIU, the current situation is not ideal: if we have something like
#+begin_src ditaa :pdf :file foo.eps, the results will be very strange.

Moreover, we have API function `org-babel-graphical-output-file' (not
used by ob-ditaa) that makes use of :file-ext standard header argument
that is serving similar purpose with :eps/:pdf in ob-ditaa (see 16.5
Evaluating Code Blocks section of the manual).

So, I view these :ext options that are still used by several babel
backends as candidates for deprecation. Certainly, I do not want to make
them proliferate in the new features.

>>> +      (message cmd)
>>> +      (shell-command cmd)
>>> +      (when pdf
>>> +	(let ((pdf-cmd (concat "epstopdf" " " ditaa-out-file " "
>>> +		              "-o=" (org-babel-process-file-name out-file))))
>>> +          (message pdf-cmd)
>>
>> Why message?
>
> I was originally directed to ob-plantuml, which message's its
> command. During the testing of this patch I found messaging useful to
> observe what was happening.
>
> So, your choice:
> a) no messaging
> b) message always
> c) defcustom a toggle for messaging?

I'd prefer no messaging as it serves no clear purpose to the user.
For debugging purposes, one can always do M-x trace-function shell-command

> And, finally, should I add myself as the maintainer?

That would be great. Thanks!
I assume that you already have access to savannah as you are
listed as the maintainer of ob-processing.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>