From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id UBKdCjLkdmdlTgAAe85BDQ:P1 (envelope-from ) for ; Thu, 02 Jan 2025 19:08:34 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id UBKdCjLkdmdlTgAAe85BDQ (envelope-from ) for ; Thu, 02 Jan 2025 20:08:34 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=WmXaxNsZ; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1735844913; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=zRSmM5Pl63c2Eq6Uk+S302SWE8MWlfSBCNWdvrVRYH8=; b=Arw+Gti3EF12nfanGRTij9XXBX54ZH1ajVzvmS5KHTdgpWgS9rrwyQRLrAO4qO238E9fGx Bmc52pY0czUQbiCdedNvuZ+jpBKoEgoOQG2gUR/NvtjVDtyzsj/3YpmYHq1+wP7d7P6Moj I5jQH3+UwbYYAF+a6rLIQqOqyXTUYypQHZZZulWCHSdmGmDSiMi5yL0nyxai+c6NTAZWir QiXuWGoPBUWAsRJLNezBph8PqHZlX/wCFSKsbYL44gwmNMaxgsBz3XPMmmH1/mbqgSyyfw 7X04cg26S5DEQP0cTCEXR3WEggJwNuxnPPBHiuoJeMZmuOyruojlu+FV9Le14w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=WmXaxNsZ; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1735844913; a=rsa-sha256; cv=none; b=jHKMmmwfwJ1zGS2EqEGbmS0Ko3Zsb9fGMKI5pGOshnIEwsyLmXmqAWrhzILc9dc9O7+dFp Gcie0xV2rA9iMHxryS5xiTniWljPEYeZWL0H+3Rh1KV4+rE5mFLCXIN8vplOdwBWmuxkFe Fe2FDvf769gCSzzyucCY0SIzE+k5yBK0NmOYqKQqc4lzAHuqP1ssqrKHnC27wsdkEd6/Wa e6xEOhO22YU75m/31aQ6ZJ8sHQeSr4i/3RAfizyIsUNB7XTwkc4Xd3VvTrH+aQVhygCWPM ShScC0iHpKVwtube/xV6/f44XG28NFS24WsgmUcyHO5vywt2IfsKgBwXbf2ePQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A7A2A8D9FC for ; Thu, 02 Jan 2025 20:08:32 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTQXh-00065v-NN; Thu, 02 Jan 2025 14:07:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTQXf-00065S-Rd for emacs-orgmode@gnu.org; Thu, 02 Jan 2025 14:07:35 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTQXd-0005Fi-JX for emacs-orgmode@gnu.org; Thu, 02 Jan 2025 14:07:35 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 2DED8240101 for ; Thu, 2 Jan 2025 20:07:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1735844851; bh=aNvcfKSVDTdNyohoV69A7B7+CXe4gCm2999p6DR5Thw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=WmXaxNsZdQGUk4NTiyNxhS79mMHzfG+iio/YgfuwAGbHsMJbnD+ABqCXT1r7lCYpn BDyDBoD7WeYixjVvHey+Ao22f0PQe/mKqYn8+MVrMbPhyWv8/CHds33s0bUGiFbJuV ucpufO7M5lDOxTf3bw6VvjMZMeAXn3IYVIoeGELzoV26b/ju+bA/+atVVwtud2CBcL OvGQ0dylDnqOl2LT6QS3MjEqx+pnd5tSsIop5hhvZZa0k2awh0HmNobGEyy+peswZ4 QEK7YDj686X2gaB23tcM5x81RlWOkXZappGG8h/G15iUaJ5YI+WkDPP2cXEMIr6PL3 pgLDF80pFFF/Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YPGRk5dJ7z9rxK; Thu, 2 Jan 2025 20:07:30 +0100 (CET) From: Ihor Radchenko To: Malcolm Purvis Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] Add next-error support to org-lint report buffer In-Reply-To: References: <874j2tibsn.fsf@localhost> <87cyhb970e.fsf@localhost> Date: Thu, 02 Jan 2025 19:09:50 +0000 Message-ID: <878qrtqbgh.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: -5.99 X-Spam-Score: -5.99 X-Migadu-Queue-Id: A7A2A8D9FC X-TUID: ZTXVg79+XRtO Malcolm Purvis writes: > Thanks for the review and happy new year.. > >>> -| {{{kbd(S)}}} | Sort reports by the column at point | >> Looks like you deleted this line by accident. > > I've restored this in the patch below. I think you can simply squash the fix with the original patch. >> I just tried your patch on an Org file with 2 warnings and tried >> to press C-x ` repeatedly. Upon moving to the last line in *Org >> lint* buffer, I got > > This is a bug in the original org-lint code, where this error was > raised it you pressed on the line after the list in the > report. The next error code just did the same thing. > > I've included a fix for that to ignore requests to just to the > source when not in the list of errors. Thanks! This indeed fixed the problem I described. There is another problem though. Consider: 1. M-x org-lint 2. Switch back to the original .org buffer 3. M-g M-n 4. Observe link report and .org window swapped and point moving back to the lint report. It is not what usually happens with error navigation (e.g. during compile or grep navigation) > +| {{{kbd(C-x `)}}} | Move to the next report and display the offending line | May as well mention M-g M-n and maybe `previous-error' (M-g M-p) -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at . Support Org development at , or support my work at