emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Malcolm Purvis <malcolm@purvis.id.au>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Add next-error support to org-lint report buffer
Date: Thu, 02 Jan 2025 19:09:50 +0000	[thread overview]
Message-ID: <878qrtqbgh.fsf@localhost> (raw)
In-Reply-To: <m2jzbd1nr5.fsf@purvis.id.au>

Malcolm Purvis <malcolm@purvis.id.au> writes:

> Thanks for the review and happy new year..
>  
>>> -| {{{kbd(S)}}} | Sort reports by the column at point | 
>> Looks like you deleted this line by accident. 
>
> I've restored this in the patch below.

I think you can simply squash the fix with the original patch.
  
>> I just tried your patch on an Org file with 2 warnings and tried 
>> to press C-x ` repeatedly. Upon moving to the last line in *Org 
>> lint* buffer, I got 
>  
> This is a bug in the original org-lint code, where this error was 
> raised it you pressed <RET> on the line after the list in the 
> report.  The next error code just did the same thing.
>
> I've included a fix for that to ignore requests to just to the 
> source when not in the list of errors.

Thanks!
This indeed fixed the problem I described.

There is another problem though.
Consider:
1. M-x org-lint
2. Switch back to the original .org buffer
3. M-g M-n
4. Observe link report and .org window swapped and point moving back to
   the lint report. It is not what usually happens with error navigation
   (e.g. during compile or grep navigation)

> +| {{{kbd(C-x `)}}}               | Move to the next report and display the offending line |

May as well mention M-g M-n and maybe `previous-error' (M-g M-p)

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2025-01-02 19:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-14  7:25 [PATCH] Add next-error support to org-lint report buffer Malcolm Purvis
2024-12-24 11:02 ` Ihor Radchenko
2024-12-27 23:42   ` Malcolm Purvis
2024-12-28 15:12     ` Ihor Radchenko
2025-01-02 11:03       ` Malcolm Purvis
2025-01-02 19:09         ` Ihor Radchenko [this message]
2025-01-04 10:48           ` Malcolm Purvis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878qrtqbgh.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=malcolm@purvis.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).