* Language support for C# in org-babel
@ 2025-01-06 17:44 poverobuosodonati
2025-01-06 18:19 ` Leo Butler
0 siblings, 1 reply; 4+ messages in thread
From: poverobuosodonati @ 2025-01-06 17:44 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 947 bytes --]
Hi guys,
I am a newbie in that I've never contributed so far. Thus, I would like to start this journey with pinging the mailing list first as it is indicated in the contributing documentation.
As far as I know, there is currently no language support for C# withi org-babel.
As this (evaluating C# code-blocks) is occasionally helpful for my workflow, I went ahead and wrote an integration following the excellent documentation found here (https://orgmode.org/worg/org-contrib/babel/languages/index.html).
Are there any objections against me trying to upstream this addition? I would go ahead and try to open a pull request following the guidelines from this documentation (https://orgmode.org/worg/org-contribute.html) if there are none. Or is there a better way/no need for it in the first place?
I am happy about any feedback on the matter :)
Thank you very much in advance,
Best regards,
Max
[-- Attachment #2: Type: text/html, Size: 2044 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Language support for C# in org-babel
2025-01-06 17:44 Language support for C# in org-babel poverobuosodonati
@ 2025-01-06 18:19 ` Leo Butler
2025-01-06 21:09 ` Buoso Donati
0 siblings, 1 reply; 4+ messages in thread
From: Leo Butler @ 2025-01-06 18:19 UTC (permalink / raw)
To: poverobuosodonati; +Cc: emacs-orgmode
On Mon, Jan 06 2025, poverobuosodonati <poverobuosodonati@gmail.com> wrote:
>
>
>
>
> Hi guys,
>
>
>
> I am a newbie in that I've never contributed so far. Thus, I would like to start this journey with pinging the mailing list first as it is indicated in the contributing documentation.
>
Welcome.
>
>
> As far as I know, there is currently no language support for C# withi org-babel.
>
> As this (evaluating C# code-blocks) is occasionally helpful for my
> workflow, I went ahead and wrote an integration following the
> excellent documentation found here
> (https://orgmode.org/worg/org-contrib/babel/languages/index.html).
Have you looked at ob-C.el or ob-java.el? I am not sure how similar C#
is to either C/C++/D or Java, but it may make sense to try to extend one
of those.
>
> Are there any objections against me trying to upstream this addition?
> I would go ahead and try to open a pull request following the
> guidelines from this documentation
> (https://orgmode.org/worg/org-contribute.html) if there are none. Or
> is there a better way/no need for it in the first place?
See the instructions at
https://orgmode.org/worg/org-contribute.html#first-patch
Best regards,
Leo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Language support for C# in org-babel
2025-01-06 18:19 ` Leo Butler
@ 2025-01-06 21:09 ` Buoso Donati
2025-01-07 18:04 ` Ihor Radchenko
0 siblings, 1 reply; 4+ messages in thread
From: Buoso Donati @ 2025-01-06 21:09 UTC (permalink / raw)
To: Leo Butler; +Cc: emacs-orgmode
Thanks a lot for your input!
> Have you looked at ob-C.el or ob-java.el? I am not sure how similar C#
> is to either C/C++/D or Java, but it may make sense to try to extend one
> of those.
In fact, I was most inspired by the existing ob-C.el and ob-java.el!
From what I understand C# (in conjunction with csproj-files) is
"different enough" from C/C++ and Java (I don't feel particularly
comfortable judging the D language) that it somewhat makes sense to
create an individual file integrating it (as opposed to increase the
complexity with existing integrations).
I will however consider this and re-evaluate my initial concept with
your feedback.
> See the instructions at
>
> https://orgmode.org/worg/org-contribute.html#first-patch
I would go ahead and follow these instructions trying to contribute the
draft. This also makes it easier for me to show what I mean and
elaborate on the concept (and the differences to existing integrations)
potentially.
Best regards,
Max
On 06.01.25 19:19, Leo Butler wrote:
> On Mon, Jan 06 2025, poverobuosodonati <poverobuosodonati@gmail.com> wrote:
>
>>
>>
>>
>>
>> Hi guys,
>>
>>
>>
>> I am a newbie in that I've never contributed so far. Thus, I would like to start this journey with pinging the mailing list first as it is indicated in the contributing documentation.
>>
> Welcome.
>
>>
>> As far as I know, there is currently no language support for C# withi org-babel.
>>
>> As this (evaluating C# code-blocks) is occasionally helpful for my
>> workflow, I went ahead and wrote an integration following the
>> excellent documentation found here
>> (https://orgmode.org/worg/org-contrib/babel/languages/index.html).
> Have you looked at ob-C.el or ob-java.el? I am not sure how similar C#
> is to either C/C++/D or Java, but it may make sense to try to extend one
> of those.
>
>>
>> Are there any objections against me trying to upstream this addition?
>> I would go ahead and try to open a pull request following the
>> guidelines from this documentation
>> (https://orgmode.org/worg/org-contribute.html) if there are none. Or
>> is there a better way/no need for it in the first place?
> See the instructions at
>
> https://orgmode.org/worg/org-contribute.html#first-patch
>
> Best regards,
> Leo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Language support for C# in org-babel
2025-01-06 21:09 ` Buoso Donati
@ 2025-01-07 18:04 ` Ihor Radchenko
0 siblings, 0 replies; 4+ messages in thread
From: Ihor Radchenko @ 2025-01-07 18:04 UTC (permalink / raw)
To: Buoso Donati; +Cc: Leo Butler, emacs-orgmode
Buoso Donati <poverobuosodonati@gmail.com> writes:
> Are there any objections against me trying to upstream this addition?
C# is a popular language. I have no objections to adding it to the core.
> ... I would go ahead and try to open a pull request following the
> guidelines from this documentation
> (https://orgmode.org/worg/org-contribute.html) if there are none. Or
> is there a better way/no need for it in the first place?
If you can, please do follow what is written in our contribution guide.
But feel free to ask us anything if you encounter difficulties.
You do not have to go through all the requirements alone.
> In fact, I was most inspired by the existing ob-C.el and ob-java.el!
> From what I understand C# (in conjunction with csproj-files) is
> "different enough" from C/C++ and Java (I don't feel particularly
> comfortable judging the D language) that it somewhat makes sense to
> create an individual file integrating it (as opposed to increase the
> complexity with existing integrations).
> I will however consider this and re-evaluate my initial concept with
> your feedback.
Generally, it only makes sense to extend an existing library if there is
very significant code sharing. Otherwise, no need to complicate things.
Also, before you proceed, note that there is ob-csharp in org-contrib
repository:
https://git.sr.ht/~bzg/org-contrib/tree/master/item/lisp/ob-csharp.el
It is very simplistic though. Just letting you know so that you are
aware.
You do not need to reuse that file or anything like that - we *cannot*
use that file because its author did not sign copyright papers. (BTW,
you do need to do it - let me know if you need any assistance)
After your future patch is accepted, we will likely remove ob-csharp
from org-contrib. Which means that you should name the new library
ob-csharp as well - it will serve as the replacement.
--
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-01-07 18:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-06 17:44 Language support for C# in org-babel poverobuosodonati
2025-01-06 18:19 ` Leo Butler
2025-01-06 21:09 ` Buoso Donati
2025-01-07 18:04 ` Ihor Radchenko
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).