emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Manuel Giraud <manuel.giraud@univ-nantes.fr>
To: Jambunathan K <kjambunathan@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-html.el: Fix export of table.el tables.
Date: Tue, 26 Apr 2011 17:14:36 +0200	[thread overview]
Message-ID: <877hahqc2r.fsf@univ-nantes.fr> (raw)
In-Reply-To: <81tydljf74.fsf@gmail.com> (Jambunathan K.'s message of "Tue, 26 Apr 2011 19:19:03 +0530")

Jambunathan K <kjambunathan@gmail.com> writes:

> Our understanding matches. For the sake of clarity, here it is:
>
> For simple tables,
> 1. org-export-prefer-native-exporter-for-tables => Non-nil => Use the
>    HTML code generator in table.el => HTML *source code* has Lots of
>    &nbsp
>
> 2. org-export-prefer-native-exporter-for-tables => nil => Use Org's own
>    code generator => HTML *source code* is easy to look at.

Yes. The rendered HTML output is prettier with your patch. It is just
the HTML source that is full of &nbsp;. But now, I understand that it
comes from table.el.

> [snip]
> May be you are exporting a different table.el table? Can you post your
> example? 

No, I've used your example to test your patch.

> With point within a simple table.el-table, the elisp form down
> below should eval to false. Is it any different in your setting? 
>
> #+begin_src emacs-lisp
> (let* ((dim (table-query-dimension))
>        (c (nth 4 dim)) (r (nth 5 dim)) (cells (nth 6 dim)))
>   (not (= (* c r) cells)))
> #+end_src

Yes. It is false for simple table without spanning so I guess it's ok.

> It is possible that I have misunderstood how table-query-dimension API
> works ...

No, it's ok and it is my fault: I was worried about the complex HTML
output but now I understood that it is so for spanning table that are
rendered by table.el (and as I said I'm no HTML table expert so I guess
that table.el is the right thing when it comes to complex tables).

Best,
-- 
Manuel Giraud

  reply	other threads:[~2011-04-26 15:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-24 22:42 [PATCH] org-html.el: Fix export of table.el tables Jambunathan K
2011-04-24 22:47 ` Jambunathan K
2011-04-26 12:55 ` Manuel Giraud
2011-04-26 12:57   ` Manuel Giraud
2011-04-26 13:49     ` Jambunathan K
2011-04-26 15:14       ` Manuel Giraud [this message]
2011-05-24 13:06 ` [Accepted] " Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877hahqc2r.fsf@univ-nantes.fr \
    --to=manuel.giraud@univ-nantes.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=kjambunathan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).