From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@altern.org>
Subject: Re: [PATCH 1/2] Simplify org-clocktable-indent-string.
Date: Fri, 20 Apr 2012 13:12:07 +0200
Message-ID: <877gxa1wu0.fsf@altern.org>
References: <80k421mf5q.fsf@somewhere.org>
	<1333238367-27755-1-git-send-email-girard.nicolas@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:40761)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1SLBjv-0005FD-A4
	for emacs-orgmode@gnu.org; Fri, 20 Apr 2012 07:11:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1SLBjt-0008Lf-2Y
	for emacs-orgmode@gnu.org; Fri, 20 Apr 2012 07:10:58 -0400
Received: from mail-wi0-f177.google.com ([209.85.212.177]:36389)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1SLBjs-0008LS-Qd
	for emacs-orgmode@gnu.org; Fri, 20 Apr 2012 07:10:57 -0400
Received: by wibhj13 with SMTP id hj13so422179wib.12
	for <emacs-orgmode@gnu.org>; Fri, 20 Apr 2012 04:10:54 -0700 (PDT)
In-Reply-To: <1333238367-27755-1-git-send-email-girard.nicolas@gmail.com>
	(Nicolas Girard's message of "Sun, 1 Apr 2012 01:59:26 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Nicolas Girard <girard.nicolas@gmail.com>
Cc: emacs-orgmode@gnu.org

Hi Nicolas,

Nicolas Girard <girard.nicolas@gmail.com> writes:

> ---
>  lisp/org-clock.el |    6 +-----
>  1 files changed, 1 insertions(+), 5 deletions(-)
>
> diff --git a/lisp/org-clock.el b/lisp/org-clock.el
> index 591f59c..be66ce6 100644
> --- a/lisp/org-clock.el
> +++ b/lisp/org-clock.el
> @@ -2342,11 +2342,7 @@ from the dynamic block definition."
>  (defun org-clocktable-indent-string (level)
>    (if (= level 1)
>        ""
> -    (let ((str "\\__"))
> -      (while (> level 2)
> -	(setq level (1- level)
> -	      str (concat str "___")))
> -      (concat str " "))))
> +    (concat "\\" (make-string (* 2 (1- level)) ?_ ) " ")))
>  
>  (defun org-clocktable-steps (params)
>    "Step through the range to make a number of clock tables."

The "simplification" does not produce the same output.

I rejected this patch.

-- 
 Bastien