From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: Fix to property inheritance Date: Mon, 07 Jan 2013 18:35:42 +0100 Message-ID: <877gnoc2g8.fsf@bzg.ath.cx> References: Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([208.118.235.92]:45433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsGkx-0002eu-Si for emacs-orgmode@gnu.org; Mon, 07 Jan 2013 12:45:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TsGkr-0006SS-IT for emacs-orgmode@gnu.org; Mon, 07 Jan 2013 12:45:03 -0500 Received: from mail-we0-f175.google.com ([74.125.82.175]:55462) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsGkr-0006S4-Ch for emacs-orgmode@gnu.org; Mon, 07 Jan 2013 12:44:57 -0500 Received: by mail-we0-f175.google.com with SMTP id z53so10363354wey.20 for ; Mon, 07 Jan 2013 09:44:56 -0800 (PST) In-Reply-To: (Bill Wishon's message of "Sat, 15 Dec 2012 22:24:30 -0800") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bill Wishon , schulte eric Cc: emacs-orgmode Hi Bill, sorry for the late (and probably disappointing) reply. Bill Wishon writes: > This is my first major org-mode contribution, and I'm new to git, so > if there is something I haven't got quite right in terms of how to > contribute please advise. > > org-entry-get with inherit set didn't work for sub-heading additions > or overrides to properties found in parent headings as of Org-mode > version 7.9.2 (release_7.9.2-738-g442b2a-git @ org-loaddefs.el can > not be found!).   > > An example test org-mode file is attached (modified from the testing/ > examples directory and also updated in my git repository). Thanks for providing such a file with tests and examples. As far as I understand, problems are for cumulative properties, right? Eric, do you have time to check Bill's tests and see what's wrong with cumulative properties and inheritance? I'm not familiar enough with this part of the code to *enjoy* fixing this :) As for the patch themselves... 1) I did not receive confirmation from the FSF copyright clerk that your assignment is processed -- let me know if it is; 2) Please shrink commit messages and code lines to < 75 characters when possible. See org.el: we avoid long lines. This is not only for code readability, but also - and importantly here - for patch readability... If I overlooked a bug about something else than cumulative props, please let me know and let's have a separate fix for it. Thanks! -- Bastien