emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Ingo Lohmar <i.lohmar@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] fix org-insert-todo-heading-respect-content in plain list item
Date: Mon, 28 Oct 2013 09:43:40 +0100	[thread overview]
Message-ID: <877gcxbxab.fsf@gmail.com> (raw)
In-Reply-To: <878uxeu0bh.fsf@acer.localhost.com> (Ingo Lohmar's message of "Sun, 27 Oct 2013 17:48:34 +0100")

Hello,

Ingo Lohmar <i.lohmar@gmail.com> writes:

> please find attached a 1-4-char patch fixing the behavior of the above
> function when inside a plain list.

[...]

> Subject: [PATCH] fix org-insert-todo-heading-respect-content in plain list item
>
> * lisp/org.el (org-insert-todo-heading-respect-content): pass correct
> prefix arg to always insert heading
>
> TINYCHANGE
>
> This function used a second argument t, which is eventually passed to
> org-insert-heading, adding a list item when inside a plain list.  Use
> the proper argument '(4) now, to always create a heading, just like
> the function's name and documentation imply.

Thank you for your patch.

Could you provide a test case, because, after a quick test, I do not see
any difference before and after applying your patch.


Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2013-10-28  8:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-27 16:48 [PATCH] fix org-insert-todo-heading-respect-content in plain list item Ingo Lohmar
2013-10-28  8:43 ` Nicolas Goaziou [this message]
2013-10-28 19:35   ` Ingo Lohmar
2013-10-29  8:58     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877gcxbxab.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=i.lohmar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).