From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [Exporter] Why fall-back to :title if :alt-title is nil? Date: Sat, 16 Nov 2013 12:01:02 +0100 Message-ID: <877gc8k3v5.fsf@gmail.com> References: <87li0olk4h.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40802) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhdcT-0003AV-Fw for emacs-orgmode@gnu.org; Sat, 16 Nov 2013 06:01:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VhdcK-0006mB-SH for emacs-orgmode@gnu.org; Sat, 16 Nov 2013 06:00:53 -0500 Received: from mail-ea0-x234.google.com ([2a00:1450:4013:c01::234]:42156) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhdcK-0006m7-Kc for emacs-orgmode@gnu.org; Sat, 16 Nov 2013 06:00:44 -0500 Received: by mail-ea0-f180.google.com with SMTP id b11so1746113eae.25 for ; Sat, 16 Nov 2013 03:00:43 -0800 (PST) In-Reply-To: <87li0olk4h.fsf@gmail.com> (Thorsten Jolitz's message of "Sat, 16 Nov 2013 11:24:30 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Thorsten Jolitz Cc: emacs-orgmode@gnu.org Hello, Thorsten Jolitz writes: > Hi List, > > in ox.el I find this function for getting the (optional) alternative title of > a headline: > > #+begin_src emacs-lisp > (defun org-export-get-alt-title (headline info) > "Return alternative title for HEADLINE, as a secondary string. > INFO is a plist used as a communication channel. If no optional > title is defined, fall-back to the regular title." > (or (org-element-property :alt-title headline) > (org-element-property :title headline))) > #+end_src > > I'm not so sure that it is a good idea to fallback to the regular title in > case :alt-title is nil, because when extracting both, title and alt-title, > from a headline, there is a almost always a duplication (the regular title > string is received two times, via the get-title and get-alt-title functions) > because :alt-title isn't really set very often. > > Wouldn't it make more sense to just return nil when :alt-title is nil? If the > application code needs a title string anyway, it can always fall-back to a > call to the get-title function. There is no "get-title" function. When building a TOC, you are required to get a title for the current entry. This function prevent checking both sources. Anyway, I think this is nitpicking, because you can always check if its return value equals (org-element-property :title headline). Regards, -- Nicolas Goaziou