From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] org.el: make org-paragraph-fill ignore \[...\] regions
 starting and ending a line
Date: Sat, 16 Aug 2014 11:46:55 +0200
Message-ID: <877g28ojg0.fsf@nicolasgoaziou.fr>
References: <CAKrPhPORpnVDwsrJnbioK3V9+SmMjDcjNazhE6ZUitUFPEhxEw@mail.gmail.com>
	<87mwbbp45b.fsf@nicolasgoaziou.fr>
	<CAKrPhPOhBeeOyBMbdRttym688c5Zz2kyEgNv=OuWYnWSin9aZQ@mail.gmail.com>
	<874mxiizgg.fsf@gmx.us> <87lhqubvtd.fsf@nicolasgoaziou.fr>
	<CAKrPhPN2Wa6pS4voukxQfRn=M0co-77OFvzHLQZR1eY-kBrgdQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52142)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1XIaZ2-0002YX-D5
	for emacs-orgmode@gnu.org; Sat, 16 Aug 2014 05:46:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1XIaYu-0005Fy-Tb
	for emacs-orgmode@gnu.org; Sat, 16 Aug 2014 05:46:20 -0400
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:44037)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1XIaYu-0005Fu-NU
	for emacs-orgmode@gnu.org; Sat, 16 Aug 2014 05:46:12 -0400
In-Reply-To: <CAKrPhPN2Wa6pS4voukxQfRn=M0co-77OFvzHLQZR1eY-kBrgdQ@mail.gmail.com>
	(Federico Beffa's message of "Sat, 16 Aug 2014 09:50:07 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Federico Beffa <beffa@ieee.org>
Cc: emacs-orgmode@gnu.org, Rasmus <rasmus@gmx.us>

Hello,

Federico Beffa <beffa@ieee.org> writes:

> From the elisp manual:
> "...   Advising a function can cause confusion in debugging, since people
> who debug calls to the original function may not notice that it has
> been modified with advice.  Therefore, if you have the possibility to
> change the code of that function to run a hook, please solve the
> problem that way.  ..."
>
> Given that people have different opinions on this, a hook would
> actually be a good idea. It would give more freedom to the users.

Advising is a good user-side mechanism, much more powerful than hooks.
Since it is /user-side/ you should know that it has been modified with
your own advice.

Anyway filling is mode's job, not user's. Again, if you want to take
over this job, use `defadvice', in your config. A hook is pointless, if
not dangerous (the task is not trivial and there are many pitfalls that
could break the structure of the document), here.

No hook in `org-fill-paragraph', please.


Regards,

-- 
Nicolas Goaziou                                                0x80A93738