From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Beck Subject: Re: [PATCH] Fix massive slowdown in org-id-find Date: Tue, 24 Mar 2015 12:05:32 +0100 Message-ID: <877fu6u03n.fsf@sophokles.streitblatt.de> References: <87bnjj2565.fsf@sophokles.streitblatt.de> <87vbhrnz07.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaMh4-00010Z-RW for emacs-orgmode@gnu.org; Tue, 24 Mar 2015 07:08:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YaMh1-00072p-Hl for emacs-orgmode@gnu.org; Tue, 24 Mar 2015 07:08:22 -0400 Received: from plane.gmane.org ([80.91.229.3]:46146) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaMh1-00072D-Al for emacs-orgmode@gnu.org; Tue, 24 Mar 2015 07:08:19 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1YaMg6-0004iH-Pg for emacs-orgmode@gnu.org; Tue, 24 Mar 2015 12:07:22 +0100 Received: from ip-77-24-163-174.web.vodafone.de ([77.24.163.174]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 24 Mar 2015 12:07:22 +0100 Received: from fb by ip-77-24-163-174.web.vodafone.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 24 Mar 2015 12:07:22 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org > Would you mind elaborating a bit? Slow down doing what? In which cases? A fraction of a second vs 10 seconds when executing a function that calls org-id-find. The slowdowwn is not quite as massive since I cleaned up org-id-files a bit, however. > Could you profile it? I'll look into it. > Here, it catches false positives, e.g., lines looking like properties in > example blocks. It also overlooks accumulated values. This is true. However that is not really relevant for id searches, is it? In the worst case, you'll find ids in example, etc blocks when you SEARCH for them. I guess, you want to use org-find-property in other places as well. In that case org-id-find could maybe use a faster, simplified version? Let me see, if I can do some profiling tonight. > It should fail with "make test". Doesn't work for me (it hangs). -- Florian Beck