From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Florian Beck <fb@miszellen.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix massive slowdown in org-id-find
Date: Wed, 25 Mar 2015 14:04:35 +0100 [thread overview]
Message-ID: <877fu5mdng.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87twxarox9.fsf@sophokles.streitblatt.de> (Florian Beck's message of "Tue, 24 Mar 2015 23:49:54 +0100")
Florian Beck <fb@miszellen.de> writes:
>>> Could you profile it?
>
> Here are the results:
>
> With my setup and the patch I get, using
>
> (let ((time (current-time)))
> (org-id-find "zangwill.nick_2014:aesthetic.judgment")
> (format "%ss" (time-to-seconds (time-subtract (current-time) time))))
>
> --> "0.027756516s"
>
> Without my patch, the result is
>
> --> "16.104403749s"
>
> profile-report returns:
>
> - command-execute 16095 99%
> - call-interactively 16095 99%
> - funcall-interactively 15905 98%
> - eval-last-sexp 15879 98%
> - elisp--eval-last-sexp 15879 98%
> - eval 15879 98%
> - let 15879 98%
> - org-id-find 15879 98%
> - org-id-find-id-in-file 15879 98%
> - org-find-entry-with-id 15879 98%
> - org-find-property 15879 98%
> - save-excursion 15879 98%
> - let 15879 98%
> - catch 15879 98%
> - while 15879 98%
> - if 13311 82%
> - if 13311 82%
> - equal 13311 82%
> - org-entry-get 11955 74%
> - org-get-property-block 8876 55%
> - org-inlinetask-in-task-p 3329 20%
> org-inlinetask-outline-regexp 12 0%
> - org-back-to-heading 3009 18%
> - outline-back-to-heading 2000 12%
> outline-on-heading-p 4 0%
> org-before-first-heading-p 880 5%
> org-get-limited-outline-regexp 24 0%
> - #<compiled 0x3e8f1b9> 939 5%
> match-string-no-properties 44 0%
> - execute-extended-command 20 0%
> - sit-for 16 0%
> redisplay 16 0%
> + command-execute 4 0%
> + previous-line 6 0%
> + byte-code 190 1%
> + timer-event-handler 15 0%
> + ... 0 0%
Thank you.
Could you also send and updated patch containing the VALUE optional
argument to `org-re-property' and changing modifying only the (re ...)
line in `org-find-property', with a new profiling?
Regards,
next prev parent reply other threads:[~2015-03-25 13:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 13:51 [PATCH] Fix massive slowdown in org-id-find Florian Beck
2015-03-23 22:13 ` Nicolas Goaziou
2015-03-24 9:02 ` Sebastien Vauban
2015-03-24 11:05 ` Florian Beck
2015-03-24 22:49 ` Florian Beck
2015-03-25 11:31 ` Jacob Nielsen
2015-03-25 13:04 ` Nicolas Goaziou [this message]
2015-03-30 20:43 ` Florian Beck
2015-03-31 10:01 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fu5mdng.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=fb@miszellen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).