From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: replace letf with cl-letf in org-mime
Date: Wed, 01 Apr 2015 21:46:01 +0200 [thread overview]
Message-ID: <877ftvy6me.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87384k619d.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Wed, 01 Apr 2015 10:17:02 +0800")
Eric Abrahamsen <eric@ericabrahamsen.net> writes:
> If I remove the two `eval's and treat "hook" like a normal variable, the
> call to `length' fails with:
>
> Wrong type argument: sequencep, org-mime-pre-org-hook
>
> So apparently `length' is seeing the symbol name, and not the symbol
> value.
Indeed.
> I tried changing the `let' to look like:
>
> (let ((hook (symbol-value (intern (....
What about (length (symbol-value hook)) instead?
> Here's a fixed version of the previous patch.
Thank you. Applied.
> I suppose I could also alter the "bhook" thing to use `symbol-value'
> instead of `eval', but that doesn't seem to be a net gain.
IMO, anything is a net gain compared to using `eval'.
Regards,
next prev parent reply other threads:[~2015-04-01 19:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-22 13:56 replace letf with cl-letf in org-mime Eric Abrahamsen
2015-03-22 14:16 ` Nicolas Goaziou
2015-03-22 14:30 ` Eric Abrahamsen
2015-03-30 8:34 ` Eric Abrahamsen
2015-03-31 10:42 ` Nicolas Goaziou
2015-04-01 2:17 ` Eric Abrahamsen
2015-04-01 19:46 ` Nicolas Goaziou [this message]
2015-04-02 1:33 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ftvy6me.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=eric@ericabrahamsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).