From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kosyrev Serge <_deepfire@feelingofgreen.ru>
Subject: Re: Changes to contrib
Date: Tue, 10 Nov 2015 00:51:10 +0300
Message-ID: <877flqn8oh.fsf@feelingofgreen.ru>
References: <87vb9cdauy.fsf@andromedae.feelingofgreen.ru>
	<87bnb4y527.fsf@gmx.us> <87mvumnbrp.fsf@feelingofgreen.ru>
	<87si4erj1c.fsf@gmx.us> <87fv0enars.fsf@feelingofgreen.ru>
	<87io5arhzy.fsf@gmx.us>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37755)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <_deepfire@feelingofgreen.ru>) id 1ZvuLO-0001vu-8z
	for emacs-orgmode@gnu.org; Mon, 09 Nov 2015 16:51:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <_deepfire@feelingofgreen.ru>) id 1ZvuLK-0007aW-88
	for emacs-orgmode@gnu.org; Mon, 09 Nov 2015 16:51:18 -0500
Received: from [80.92.100.69] (port=45582 helo=mail.feelingofgreen.ru)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <_deepfire@feelingofgreen.ru>) id 1ZvuLJ-0007Xq-QO
	for emacs-orgmode@gnu.org; Mon, 09 Nov 2015 16:51:14 -0500
In-Reply-To: <87io5arhzy.fsf@gmx.us> (sfid-20151110_003928_438862_6D910E5D)
	(rasmus@gmx.us's message of "Mon, 09 Nov 2015 22:16:17 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Rasmus <rasmus@gmx.us>
Cc: emacs-orgmode@gnu.org

Hi,

Rasmus <rasmus@gmx.us> writes:
> Kosyrev Serge <_deepfire@feelingofgreen.ru> writes:
>> The question is.. the only documentation for ox-taskjuggler that exists
>> in Worg, seems to only cover the surface aspects of export -- none of
>> the existing documentation touches on the multitude of details that the
>> existing code does involve itself with.
>
> OK.  There should be docstring and potentially comments, if necessary.
> Worg is a separate issue.

OK, will do.

>>> You use string-join, which is in subr-x.  I think subr-x was not a
>>> dependency before.
>>
>> Oh, indeed -- missed that!
>>
>> What should I do about it?
>
> I=E2=80=99d just use mapconcat TBH, since it=E2=80=99s just one place as =
I recall.
>
>     (equal (string-join '("a" "b") " ")
>            (mapconcat 'identity '("a" "b") " "))
>
>> Understood, will rename, then.

All done, sending mails..

--=20
=D1=81 =D1=83=D0=B2=D0=B0=D0=B6=D0=B5=D0=BD=D0=B8e=D0=BC / respectfully,
=D0=9A=D0=BE=D1=81=D1=8B=D1=80=D0=B5=D0=B2 =D0=A1=D0=B5=D1=80=D0=B3=D0=B5=
=D0=B9