From mboxrd@z Thu Jan  1 00:00:00 1970
From: npostavs@users.sourceforge.net
Subject: =?UTF-8?B?YnVnIzIzOTE3OiBQbGVhc2UgY29uc2lkZXIgbWFraW5nIEJ1ZyAj?=
 =?UTF-8?B?MjM5MTcgYSBibG9ja2VyIGZvciAyNS4xICh3YXMgUmU6IG9yZy1jYXB0dXJl?=
 =?UTF-8?B?OiBDYXB0dXJlIHRlbXBsYXRlIOKAmGfigJk6IE1hdGNoIGRhdGEgY2xvYmJl?=
 =?UTF-8?B?cmVkIGJ5IGJ1ZmZlciBtb2RpZmljYXRpb24gaG9va3Mp?=
Date: Wed, 20 Jul 2016 23:00:59 -0400
Message-ID: <877fcfd79w.fsf__24863.8689904057$1469522168$gmane$org@users.sourceforge.net>
References: <87vb066ejv.fsf@linaro.org>
	<87mvlhmv0x.fsf_-_@moondust.awandering> <837fcl5zs9.fsf@gnu.org>
	<m28tx1o6h6.fsf@newartisans.com> <87a8hgkwcb.fsf@linaro.org>
	<8360s42mcb.fsf@gnu.org> <87eg6rgmlg.fsf@gmail.com>
	<83lh0y24y6.fsf@gnu.org> <jwvmvle5udz.fsf-monnier+emacsbugs@gnu.org>
	<83eg6q1hbo.fsf@gnu.org> <jwv1t2q5jsz.fsf-monnier+emacsbugs@gnu.org>
	<83a8hd1vzi.fsf@gnu.org> <jwvzipdeibv.fsf-monnier+emacsbugs@gnu.org>
	<834m7l1u8u.fsf@gnu.org> <jwvd1m9dran.fsf-monnier+emacsbugs@gnu.org>
	<83shv4z7e8.fsf@gnu.org> <jwvfur4ch16.fsf-monnier+emacsbugs@gnu.org>
	<83inw0yw9q.fsf@gnu.org> <jwvtwfkvxsc.fsf-monnier+emacsbugs@gnu.org>
	<87bn1rdd1f.fsf@users.sourceforge.net> <83h9bjzp5i.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40366)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1bQ4FW-0001LI-Am
	for emacs-orgmode@gnu.org; Wed, 20 Jul 2016 23:02:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1bQ4FU-00026Y-AB
	for emacs-orgmode@gnu.org; Wed, 20 Jul 2016 23:02:09 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.23917.B23917.146907006727608@debbugs.gnu.org>
In-Reply-To: <83h9bjzp5i.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 21 Jul
	2016 05:43:53 +0300")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: nljlistbox2@gmail.com, jwiegley@gmail.com, rpluim@gmail.com, 23917@debbugs.gnu.org, monnier@iro.umontreal.ca, alex.bennee@linaro.org

Eli Zaretskii <eliz@gnu.org> writes:

>> From: npostavs@users.sourceforge.net
>> Cc: Eli Zaretskii <eliz@gnu.org>,  23917@debbugs.gnu.org,  nljlistbox2@gmail.com,  jwiegley@gmail.com,  rpluim@gmail.com,  alex.bennee@linaro.org
>> Date: Wed, 20 Jul 2016 20:56:28 -0400
>> 
>> >> Maybe there's a misunderstanding.  What Noam suggested was just to
>> >> move the code which adjusts search_regs.start[i] and .end[i] to before
>> >> the call to replace_range.
>> >
>> > Oh, right, that's also an option.  It might suffer from another problem,
>> > which is that the match-data will be broken while the
>> > before-change-functions are run, so if there's a save-match-data there
>> > we're back to square one.
>> 
>> Solution: adjust in between the before and after change functions.
>> Patch below.  I think there shouldn't be performance problems, although
>> it does add yet another flag to replace_range (by the way, I noticed
>> that the MARKERS flags is never 0, so it's redundant).  I tested with
>> the attached bug-23917-match-data-buffer-modhook.el.
>
> Thanks.
>
> Please also make sure bug#23869 is still fixed after this.

Following the recipe in
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=23869#11 gives me 'Lisp
error: (error "Match data clobbered by buffer modification hooks")',
that indicates it's still fixed, right?