From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: A small patch for org.el to fix error in clojure babel src block
 code ref
Date: Tue, 09 May 2017 08:41:55 +0200
Message-ID: <877f1q5y6k.fsf@nicolasgoaziou.fr>
References: <CAL1eYu+xNd0N6Vtjesmsja7CUTc3FSGLUS6uQ5xaPUbOGbdhpw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52608)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1d7yqN-00054d-8f
	for emacs-orgmode@gnu.org; Tue, 09 May 2017 02:42:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1d7yqM-0007CH-Fm
	for emacs-orgmode@gnu.org; Tue, 09 May 2017 02:41:59 -0400
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:44299)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1d7yqM-0007Bt-9Z
	for emacs-orgmode@gnu.org; Tue, 09 May 2017 02:41:58 -0400
In-Reply-To: <CAL1eYu+xNd0N6Vtjesmsja7CUTc3FSGLUS6uQ5xaPUbOGbdhpw@mail.gmail.com>
	(numbchild@gmail.com's message of "Tue, 9 May 2017 09:21:20 +0800")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: "numbchild@gmail.com" <numbchild@gmail.com>
Cc: Org-mode <emacs-orgmode@gnu.org>

Hello,

"numbchild@gmail.com" <numbchild@gmail.com> writes:

> Here is the original discussion we disscusses.
> https://github.com/jkitchin/org-ref/issues/433
>
> And Here is the patch:
>
> #+BEGIN_SRC diff
> modified   lisp/org.el
> @@ -9730,7 +9730,7 @@ active region."
>       (setq sfuns
>     (delq
>      nil (mapcar (lambda (f)
> -  (let (fs) (if (funcall f) (push f fs))))
> +  (let (fs) (if (and (stringp f) (funcall f)) (push f fs))))
>   (org-store-link-functions)))

The change above doesn't make sense, does it?

If F is a string, it cannot be funcall'ed. Since
`org-store-link-functions' only contains functions, this patch is
basically skipping the whole variable.

Regards,

-- 
Nicolas Goaziou