emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] org.el: Allow tags without keys in customization
@ 2017-08-02 19:23 Allen Li
  2017-08-05  9:07 ` Nicolas Goaziou
  0 siblings, 1 reply; 4+ messages in thread
From: Allen Li @ 2017-08-02 19:23 UTC (permalink / raw)
  To: emacs-orgmode

* lisp/org.el (org-tag-alist, org-tag-persistent-alist):
Add non-keyed tag type.
---
 lisp/org.el | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index 335d6c48a..28b206d99 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -3456,8 +3456,10 @@ See also `org-tag-persistent-alist' to sidestep
this behavior."
   :group 'org-tags
   :type '(repeat
   (choice
-   (cons   (string    :tag "Tag name")
-   (character :tag "Access char"))
+   (cons :tag "Tag with key"
+                 (string    :tag "Tag name")
+ (character :tag "Access char"))
+           (list :tag "Tag" (string :tag "Tag name"))
    (const :tag "Start radio group" (:startgroup))
    (const :tag "Start tag group, non distinct" (:startgrouptag))
    (const :tag "Group tags delimiter" (:grouptags))
@@ -3489,8 +3491,10 @@ on a per-file basis, insert anywhere in the file:
   :group 'org-tags
   :type '(repeat
   (choice
-   (cons (string    :tag "Tag name")
+   (cons :tag "Tag with key"
+                 (string    :tag "Tag name")
  (character :tag "Access char"))
+           (list :tag "Tag" (string :tag "Tag name"))
    (const :tag "Start radio group" (:startgroup))
    (const :tag "Start tag group, non distinct" (:startgrouptag))
    (const :tag "Group tags delimiter" (:grouptags))
-- 
2.14.0.rc1.383.gd1ce394fe2-goog

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] org.el: Allow tags without keys in customization
  2017-08-02 19:23 [PATCH] org.el: Allow tags without keys in customization Allen Li
@ 2017-08-05  9:07 ` Nicolas Goaziou
  2017-08-07 18:34   ` Allen Li
  0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Goaziou @ 2017-08-05  9:07 UTC (permalink / raw)
  To: Allen Li; +Cc: emacs-orgmode

Hello,

Allen Li <vianchielfaura@gmail.com> writes:

> * lisp/org.el (org-tag-alist, org-tag-persistent-alist):
> Add non-keyed tag type.

Thank you.  For some reason, I'm not able to apply your patch on "maint"
branch. Could you rebase it on top of that branch and send it again?

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] org.el: Allow tags without keys in customization
  2017-08-05  9:07 ` Nicolas Goaziou
@ 2017-08-07 18:34   ` Allen Li
  2017-08-07 21:28     ` Nicolas Goaziou
  0 siblings, 1 reply; 4+ messages in thread
From: Allen Li @ 2017-08-07 18:34 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: emacs-orgmode

* lisp/org.el (org-tag-alist, org-tag-persistent-alist):
Add non-keyed tag type.
---
 lisp/org.el | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index 4bb2345a3..32c337601 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -3574,8 +3574,10 @@ See also `org-tag-persistent-alist' to sidestep
this behavior."
   :group 'org-tags
   :type '(repeat
   (choice
-   (cons   (string    :tag "Tag name")
-   (character :tag "Access char"))
+   (cons :tag "Tag with key"
+                 (string    :tag "Tag name")
+ (character :tag "Access char"))
+           (list :tag "Tag" (string :tag "Tag name"))
    (const :tag "Start radio group" (:startgroup))
    (const :tag "Start tag group, non distinct" (:startgrouptag))
    (const :tag "Group tags delimiter" (:grouptags))
@@ -3607,8 +3609,10 @@ on a per-file basis, insert anywhere in the file:
   :group 'org-tags
   :type '(repeat
   (choice
-   (cons (string    :tag "Tag name")
+   (cons :tag "Tag with key"
+                 (string    :tag "Tag name")
  (character :tag "Access char"))
+           (list :tag "Tag" (string :tag "Tag name"))
    (const :tag "Start radio group" (:startgroup))
    (const :tag "Start tag group, non distinct" (:startgrouptag))
    (const :tag "Group tags delimiter" (:grouptags))
-- 
2.14.0.rc1.383.gd1ce394fe2-goog

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] org.el: Allow tags without keys in customization
  2017-08-07 18:34   ` Allen Li
@ 2017-08-07 21:28     ` Nicolas Goaziou
  0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2017-08-07 21:28 UTC (permalink / raw)
  To: Allen Li; +Cc: emacs-orgmode

Hello,

Allen Li <vianchielfaura@gmail.com> writes:

> * lisp/org.el (org-tag-alist, org-tag-persistent-alist):
> Add non-keyed tag type.

Applied. Thank you.

Regards,

-- 
Nicolas Goaziou                                                0x80A93738

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-08-07 21:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-02 19:23 [PATCH] org.el: Allow tags without keys in customization Allen Li
2017-08-05  9:07 ` Nicolas Goaziou
2017-08-07 18:34   ` Allen Li
2017-08-07 21:28     ` Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).