From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: text search and restriction lock bugs Date: Thu, 07 Sep 2017 15:58:30 +0200 Message-ID: <877exazk3d.fsf@nicolasgoaziou.fr> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpxKI-0002me-UE for emacs-orgmode@gnu.org; Thu, 07 Sep 2017 09:58:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dpxKE-0006bI-Ee for emacs-orgmode@gnu.org; Thu, 07 Sep 2017 09:58:39 -0400 Received: from relay2-d.mail.gandi.net ([2001:4b98:c:538::194]:43333) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dpxKE-0006Zq-8c for emacs-orgmode@gnu.org; Thu, 07 Sep 2017 09:58:34 -0400 In-Reply-To: (Samuel Wales's message of "Tue, 5 Sep 2017 14:42:32 -0700") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Samuel Wales Cc: emacs-orgmode@gnu.org Hello, Samuel Wales writes: > recent maint. these are separate, but 1 and 3 might be related, and 1 and > 2 might be related, so i hope you don't mind if i put them together. > > 1. > > is it expected behavior that if you do a restriction lock on > a subtree, then do a text search, it will include matches > from org-agenda-text-search-extra-files? imo it should not. Agreed. Fixed. > 2. > > if you remove the restriction lock and refresh the agenda, > it will produce different results. > > imo, should act as if the restriction lock were still in place. g > should refresh with the settings that were present at invocation. > sometimes you change buffer name, and run a new agenda, so that you > can have 2 agendas, one restricted and one not. Not sure I agree. > the restriction lock is not fontified nicely so it can be desirable to > remove it for editing. Is this a different bug report? > 3. > > finally, a user will sometimes bind org-agenda-files to a > list that includes some of the > org-agenda-text-search-extra-files files. to avoid showing > the same match twice, the user currently has to do > remove-duplicates. imo the agenda could do > remove-duplicates to alleviate that burden. Agreed. Fixed. Thank you. -- Nicolas Goaziou