From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: duplicated test names... are these bugs? Date: Fri, 08 Sep 2017 13:21:40 +0200 Message-ID: <877ex9wi4b.fsf@nicolasgoaziou.fr> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49600) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqHM6-0001HX-Si for emacs-orgmode@gnu.org; Fri, 08 Sep 2017 07:21:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dqHM2-0006eH-0C for emacs-orgmode@gnu.org; Fri, 08 Sep 2017 07:21:50 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:39899) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dqHM1-0006dU-PT for emacs-orgmode@gnu.org; Fri, 08 Sep 2017 07:21:45 -0400 In-Reply-To: (Stig Brautaset's message of "Thu, 07 Sep 2017 23:30:38 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Stig Brautaset Cc: org mode Hello, Stig Brautaset writes: > > Running tests on master for me, with make test, results in a single test > failure in `ob-shell/bash-uses-assoc-arrays'. While looking into that I > found that there are _two_ definitions of that in the test-ob-shell.el > file. This strikes me as unlikely to be ideal, and I decided to look a > bit further and it turns out this is not unique. Running the following > command from the top-level org-mode directory > > : $ ag --nogroup --nonumbers ert-deftest | sort | uniq -d > > Results in > > : testing/lisp/test-ob-lilypond.el:(ert-deftest ob-lilypond/ly-gen-html () > : testing/lisp/test-ob-shell.el:(ert-deftest ob-shell/bash-uses-assoc-arrays () > : testing/lisp/test-ob-shell.el:(ert-deftest ob-shell/generic-uses-no-assoc-arrays () > : testing/lisp/test-ob.el:(ert-deftest test-ob/commented-last-block-line-with-var () > : testing/lisp/test-ob.el:(ert-deftest test-ob/org-babel-remove-result--results-default () > : testing/lisp/test-ob.el:(ert-deftest test-ob/org-babel-remove-result--results-list () > : testing/lisp/test-ob.el:(ert-deftest test-ob/org-babel-remove-result--results-pp () > : testing/lisp/test-org-table.el:(ert-deftest test-org-table/align () > > I'm not super familiar with ert, but I _assume_ that this will lead to > only the last definition of the test with the duplicate names being run > by 'make test'? Fixed. Thank you. Regards, -- Nicolas Goaziou