From dc8d8d1b9bf92d9fe826cfe8a13c6ad89c1f9c8e Mon Sep 17 00:00:00 2001 From: Nicolas Goaziou Date: Wed, 1 Nov 2017 17:54:12 +0100 Subject: [PATCH] Fix failing test * testing/lisp/test-ox-publish.el (test-org-publish/resolve-external-link): Rewrite test to prevent race condition which could affect results. * testing/examples/pub/b.org: Add missing keyword. --- testing/examples/pub/b.org | 3 +++ testing/lisp/test-ox-publish.el | 34 ++++++++++++++++++---------------- 2 files changed, 21 insertions(+), 16 deletions(-) diff --git a/testing/examples/pub/b.org b/testing/examples/pub/b.org index 60387460e..261152e99 100644 --- a/testing/examples/pub/b.org +++ b/testing/examples/pub/b.org @@ -2,5 +2,8 @@ #+date: <2012-03-29 Thu> * Headline1 +:PROPERTIES: +:CUSTOM_ID: b1 +:END: [[file:a.org::#a1]] diff --git a/testing/lisp/test-ox-publish.el b/testing/lisp/test-ox-publish.el index a51190578..0c3aaedca 100644 --- a/testing/lisp/test-ox-publish.el +++ b/testing/lisp/test-ox-publish.el @@ -366,27 +366,29 @@ Unless set otherwise in PROPERTIES, `:base-directory' is set to ;; instead of internal reference, whenever possible. (should (equal - "a1" + '("a1" "b1") (let* ((ids nil) + (link-transcoder + (lambda (l c i) + (let ((option (org-element-property :search-option l)) + (path (org-element-property :path l))) + (push (org-publish-resolve-external-link option path t) + ids) + ""))) (backend (org-export-create-backend - :transcoders - '((headline . (lambda (h c i) c)) - (paragraph . (lambda (p c i) c)) - (section . (lambda (s c i) c)) - (link . (lambda (l c i) - (let ((option (org-element-property :search-option l)) - (path (org-element-property :path l))) - (when option - (throw :exit (org-publish-resolve-external-link - option path t))))))))) + :transcoders `((headline . (lambda (h c i) c)) + (paragraph . (lambda (p c i) c)) + (section . (lambda (s c i) c)) + (link . ,link-transcoder)))) (publish (lambda (plist filename pub-dir) - (push (catch :exit - (org-publish-org-to backend filename ".test" plist pub-dir)) - ids)))) - (org-test-publish (list :publishing-function (list publish)) #'ignore) - (car ids))))) + (org-publish-org-to backend filename ".test" plist pub-dir)))) + (org-test-publish (list :publishing-function (list publish) + :exclude "." + :include '("a.org" "b.org")) + #'ignore) + (sort ids #'string<))))) ;;; Tools -- 2.14.3