emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Daniel Borchmann <daniel@algebra20.de>
To: emacs-orgmode@gnu.org
Subject: Bug: links are not highlighted anymore with Org Mode 9.2
Date: Thu, 03 Jan 2019 13:18:29 +0100	[thread overview]
Message-ID: <877efmj5nu.fsf@algebra20.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 919 bytes --]


Hey,

links in Org Mode 9.2 are not highlighted anymore if no :face keyword is
given in ‘org-link-parameters’.  The reason for this seems to be that
‘org-activate-links’ uses the following code to determine which face to
use:

--8<---------------cut here---------------start------------->8---
(pcase (org-link-get-parameter type :face)
  ((and (pred functionp) face) (funcall face path))
  ((and (pred facep) face) face)
  ((and (pred consp) face) face) ;anonymous
  (_ 'org-link))
--8<---------------cut here---------------end--------------->8---

However, ‘nil’ is a valid face, and thus this form returns ‘nil’ instead
of the default ‘org-link’ face if no :face keyword is given.

Best,

  Daniel

PS: Thanks a ton for Org Mode, I literally couldn’t live without it! :)

-- 
Daniel Borchmann
GPG (Mail)            0849 473E 6BF0 B504 DF0B  D640 455E 3610 01FF 778F

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

             reply	other threads:[~2019-01-03 12:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-03 12:18 Daniel Borchmann [this message]
2019-01-03 13:45 ` Bug: links are not highlighted anymore with Org Mode 9.2 Nicolas Goaziou
2019-01-03 14:37   ` Daniel Borchmann
2019-01-03 15:15     ` Daniel Borchmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877efmj5nu.fsf@algebra20.de \
    --to=daniel@algebra20.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).