From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: xristos <xristos@sdf.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: Inconsistent usage of org-capture-get [9.2 (release_9.2 @ /Users/xristos/code/elisp/third-party/org-mode/lisp/)]
Date: Fri, 04 Jan 2019 14:19:00 +0100 [thread overview]
Message-ID: <877efkv9vf.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <335zv5k9xg.fsf@sdf.org> (xristos's message of "Thu, 03 Jan 2019 11:00:59 -0500")
Hello,
xristos <xristos@sdf.org> writes:
> At some point, the optional argument LOCAL was added to org-capture-get:
>
> (org-capture-get PROP &optional LOCAL)
>
> "When LOCAL is set, use the local variable ‘org-capture-current-plist’,
> this is necessary after initialization of the capture process,
> to avoid conflicts with other active capture processes."
>
> A lot of the org-capture-get calls in org-capture.el do not set LOCAL
> and suffer from aforementioned conflicts. The calls inside function org-capture
> are exempt from this, but the calls inside org-capture-finalize that do not
> set LOCAL are obviously erroneous. There are more org-capture-get calls in
> other functions that have to be reviewed.
Do you want to provide a patch for that?
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2019-01-04 13:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 16:00 Bug: Inconsistent usage of org-capture-get [9.2 (release_9.2 @ /Users/xristos/code/elisp/third-party/org-mode/lisp/)] xristos
2019-01-04 13:19 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877efkv9vf.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=xristos@sdf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).