[PATCH] ox-odt.el: (org-odt-template): Get write permissions on styles.xml

[PATCH] ox-odt.el: (org-odt-template): Get write permissions on styles.xml

[Nicolò Balzarotti]

[-- Attachment #1: Type: text/plain, Size: 616 bytes --]

Hello Org!

I attached a patch that is required to get ox-odt to work on
guix/nix/other distributions where package files are placed in a
read-only directory.  After the file styles.xml is copied to /tmp, now
we set read-write permissions to it before trying to write it.  Before
this patch, we got the error:

  'OpenDocument export failed: Buffer is read-only: #<killed buffer>'.

It's my first patch and is just 1 line long, so following instructions
on https://orgmode.org/worg/org-contribute.html#commit-messages I added
the TINYCHANGE cookie.  Tests (make test) are passing.

Thanks!
Nicolò


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-ox-odt.el-org-odt-template-Get-write-permissions-on-.patch --]
[-- Type: text/x-patch, Size: 1229 bytes --]

From a80be4da6880443f2b947ade03092699fa24c846 Mon Sep 17 00:00:00 2001
From: nixo <nicolo@nixo.xyz>
Date: Fri, 20 Dec 2019 11:45:11 +0100
Subject: [PATCH] ox-odt.el: (org-odt-template): Get write permissions on
 styles.xml
To: emacs-orgmode@gnu.org

(org-odt-template): The file `styles.xml' might be copied from a
location where it is read-only.  Since we need to modify it (and its
copied under /tmp, so we can modify it), we need to ensure we have
write persmissions on it.  Set mode to 600.

This is especially needed for projects like guix, where all system
files are stored in a read-only location.

TINYCHANGE
---
 lisp/ox-odt.el | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lisp/ox-odt.el b/lisp/ox-odt.el
index f9c4a93cc..b8e228246 100644
--- a/lisp/ox-odt.el
+++ b/lisp/ox-odt.el
@@ -1383,6 +1383,8 @@ original parsed data.  INFO is a plist holding export options."
 
     ;; create a manifest entry for styles.xml
     (org-odt-create-manifest-file-entry "text/xml" "styles.xml")
+    ;; ensure we have write permissions to this file
+    (set-file-modes (concat org-odt-zip-dir "styles.xml") #o600)
 
     ;; FIXME: Who is opening an empty styles.xml before this point?
     (with-current-buffer
-- 
2.24.0

Re: [PATCH] ox-odt.el: (org-odt-template): Get write permissions on styles.xml

[Nicolas Goaziou]

Hello,

anothersms@gmail.com (Nicolò Balzarotti) writes:

> I attached a patch that is required to get ox-odt to work on
> guix/nix/other distributions where package files are placed in a
> read-only directory.  After the file styles.xml is copied to /tmp, now
> we set read-write permissions to it before trying to write it.  Before
> this patch, we got the error:
>
>   'OpenDocument export failed: Buffer is read-only: #<killed buffer>'.
>
> It's my first patch and is just 1 line long, so following instructions
> on https://orgmode.org/worg/org-contribute.html#commit-messages I added
> the TINYCHANGE cookie.  Tests (make test) are passing.

Applied. Thank you!

Regards,

-- 
Nicolas Goaziou