From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jack Kamm Subject: Re: [RFC PATCH] Changes to pop-up source buffers Date: Sat, 18 Jan 2020 11:27:11 -0800 Message-ID: <877e1ok1kg.fsf@gmail.com> References: <87eevw7jqk.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:50921) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1istlN-0006aL-DY for emacs-orgmode@gnu.org; Sat, 18 Jan 2020 14:28:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1istlM-0005MH-DT for emacs-orgmode@gnu.org; Sat, 18 Jan 2020 14:28:05 -0500 Received: from mail-pj1-x1044.google.com ([2607:f8b0:4864:20::1044]:54933) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1istlM-0005LB-7O for emacs-orgmode@gnu.org; Sat, 18 Jan 2020 14:28:04 -0500 Received: by mail-pj1-x1044.google.com with SMTP id kx11so4752304pjb.4 for ; Sat, 18 Jan 2020 11:28:04 -0800 (PST) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: Samuel Wales Cc: emacs-orgmode@gnu.org Hi Sam, > for me, trying to get commands or functions that call pop-to-buffer to > behave as i need them to, which is to say, for them to use the full > (and same) window for accessibility reasons,* has been so unfixable in > the past that i had to give up. Thank you for raising this, I wasn't aware that pop-to-buffer might cause accessibility issues. I want to make sure that this patch won't cause any accessibility issues and hope I can address your concerns. What setting of org-src-window-setup are you using? If it is "current-window" or "reorganize-frame", this patch shouldn't affect you at all, as those implementations are left the same. I tested all the other options for org-src-window-setup as well, and their behavior remained the same when I tested them. Most options do call pop-to-buffer or display-buffer at some point or other, this patch mainly simplifies and unifies the way they call pop-to-buffer. This includes the "current-window" option, which calls "pop-to-buffer-same-window". So I don't think the patch should cause new accessibility problems.