From: Jack Kamm <email@example.com> To: Samuel Wales <firstname.lastname@example.org> Cc: email@example.com Subject: Re: [RFC PATCH] Changes to pop-up source buffers Date: Sat, 18 Jan 2020 11:27:11 -0800 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <CAJcAo8swShVYTRbkU5ddacbwxA8qxdwyHjGqq1PTiVEEnkmG2g@mail.gmail.com> Hi Sam, > for me, trying to get commands or functions that call pop-to-buffer to > behave as i need them to, which is to say, for them to use the full > (and same) window for accessibility reasons,* has been so unfixable in > the past that i had to give up. Thank you for raising this, I wasn't aware that pop-to-buffer might cause accessibility issues. I want to make sure that this patch won't cause any accessibility issues and hope I can address your concerns. What setting of org-src-window-setup are you using? If it is "current-window" or "reorganize-frame", this patch shouldn't affect you at all, as those implementations are left the same. I tested all the other options for org-src-window-setup as well, and their behavior remained the same when I tested them. Most options do call pop-to-buffer or display-buffer at some point or other, this patch mainly simplifies and unifies the way they call pop-to-buffer. This includes the "current-window" option, which calls "pop-to-buffer-same-window". So I don't think the patch should cause new accessibility problems.
next prev parent reply other threads:[~2020-01-18 19:28 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-18 17:33 Jack Kamm 2020-01-18 18:56 ` Samuel Wales 2020-01-18 19:27 ` Jack Kamm [this message] 2020-01-19 2:46 ` Samuel Wales 2020-01-19 3:24 ` Kyle Meyer 2020-01-19 17:13 ` Jack Kamm 2020-01-21 4:10 ` Kyle Meyer 2020-01-22 5:06 ` Jack Kamm 2020-01-25 4:18 ` Kyle Meyer 2020-01-19 5:07 ` stardiviner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [RFC PATCH] Changes to pop-up source buffers' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).