From mboxrd@z Thu Jan  1 00:00:00 1970
From: stardiviner <numbchild@gmail.com>
Subject: Re: [QUESTION] A decision about matching ob-sql.el's :engine header
 argument match sql-mode product name
Date: Thu, 30 Jan 2020 20:32:03 +0800
Message-ID: <877e195dmk.fsf@gmail.com>
References: <87tv4d5us5.fsf@gmail.com> <878slppfke.fsf@gmail.com>
Reply-To: numbchild@gmail.com
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:53517)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <numbchild@gmail.com>) id 1ix8zh-0003ko-5t
 for emacs-orgmode@gnu.org; Thu, 30 Jan 2020 07:32:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <numbchild@gmail.com>) id 1ix8zf-0001s3-7h
 for emacs-orgmode@gnu.org; Thu, 30 Jan 2020 07:32:24 -0500
Received: from [183.246.143.250] (port=8898 helo=dark.localdomain)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <numbchild@gmail.com>) id 1ix8zX-0001Z4-PQ
 for emacs-orgmode@gnu.org; Thu, 30 Jan 2020 07:32:22 -0500
In-reply-to: <878slppfke.fsf@gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
To: emacs-orgmode@gnu.org


Tim Cross <theophilusx@gmail.com> writes:

> My vote would be to modify ob-sql and change the hard coded values into
> a custom variable. Then users can add/remove/modify engine names to suit
> their requirements. The default should probably match the product names
> supported by sql.el (you could even have multiple entries mapping to the
> same product name for backwards compatibility i.e. 'postgres' =>
> 'postgres', 'postgresql' => 'postgres' etc.). It would also be trivial
> to then add new 'products' in the future.

Sounds great. I agree with this too.

>
> stardiviner <numbchild@gmail.com> writes:
>
>> I'm writing a patch which try to set ~sql-product~ when editing sql src block.
>>
>> Here is the code:
>>
>> #+begin_src emacs-lisp
>> (defun org-babel-edit-prep:sql (info)
>>   "Set `sql-product' in Org edit buffer.
>> Set `sql-product' in Org edit buffer according to the
>> corresponding :engine source block header argument."
>>   (let ((product (cdr (assq :engine (nth 2 info)))))
>>     (sql-set-product product)))
>> #+end_src
>>
>> But =ob-sql.el= source code hardcoded ~:engine~ names which some are not matched
>> with ~sql-product-alist~ in =sql-mode=. For example =:engine postgresql=, but it's
>> ~postgres~ in ~sql-product-alist~.
>>
>> For now, I have two solutions:
>>
>> 1. write an adapter function which translate ~:engine~ header argument value into
>>    ~sql-product-alist~ product names. This is a safe way, which will not
>>    incompatiable with old Org document.
>>
>> 2. modify source code hardcoded ~:engine~ names (also need to update Org
>>    document), this has a minor advantage is *consistance*.
>>
>> WDYT?
>>
>> BTW, about writing an adapter function to translate names. I want to hear some
>> suggestion about use which method. Writing an hash map or assoc list etc?
>>
>> Regards


-- 
[ stardiviner ]
       I try to make every word tell the meaning what I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3