From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [PATCH] (Tiny) Tweak Python session null return value Date: Mon, 17 Feb 2020 18:42:37 +0100 Message-ID: <877e0lp0tu.fsf@gnu.org> References: <87a75hfah9.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:39773) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j3kPo-0000kc-J1 for emacs-orgmode@gnu.org; Mon, 17 Feb 2020 12:42:42 -0500 In-Reply-To: <87a75hfah9.fsf@gmail.com> (Jack Kamm's message of "Mon, 17 Feb 2020 08:24:18 -0800") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: Jack Kamm Cc: emacs-orgmode@gnu.org Hi Jack, Jack Kamm writes: > Below is a very small patch to Python session blocks, to make them > return a blank result (empty string) instead of None when there is no > return value. > > Normally I would push this myself, but since we are so close to 9.4, I > thought it prudent to mail a patch and let the maintainers handle it. It > would be nice to include in 9.4, but not a big deal if I've missed the > window. Applied, thanks for the patch and the precaution not to commit it directly. > Now for an explanation of the patch: 9.4 changes Python session blocks > to fix several bugs and improve robustness overall [0]. However, there > is a cost to these fixes, which is that the session blocks can only > return a result when it is a top-level expression on the last line of > the block. If the last line is not a top-level expression, the block > would previously print "None". However, after some testing, I think this > is a little counter-intuitive, and it would be better if it returned a > blank (empty) result instead of "None". I've seen you update the NEWS entry, which is good: is there a way to present the enhancements in the "* New features" section? If you feel like it, please advertize the enhancements there too. Thanks, -- Bastien