Habit error

Habit error

[Colin Baxter]

Hello,

With the latest pull of org-mode I now find habits are not displayed
correctly in agenda. The graph bar is missing, with the error

org-habit-insert-consistency-graphs: Wrong type argument:
number-or-marker-p, nil

----- Begin debugger output --

Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil)
  (org-habit-build-graph (737610 1 737613 4 nil ".+") (24292 37530 669050 863000) (24320 16922 669050 863000) (24329 31898 669050 863000))
  (org-habit-insert-consistency-graphs)
  (org-agenda-finalize)
  (org-agenda-list nil)
  (funcall-interactively org-agenda-list nil)
  (call-interactively org-agenda-list)
  (org-agenda nil)
  (funcall-interactively org-agenda nil)
  (call-interactively org-agenda nil nil)
  (command-execute org-agenda)

----- End debugger output --

The error does not occur with the 'built-in' Org mode version 9.3 for
emacs-27.

Best wishes,

Colin.


Colin Baxter
URL: http://www.Colin-Baxter.com

Re: Habit error

[Milan Zamazal]

>>>>> "CB" == Colin Baxter <m43cap@yandex.com> writes:

    CB> Hello,
    CB> With the latest pull of org-mode I now find habits are not displayed
    CB> correctly in agenda. The graph bar is missing, with the error

    CB> org-habit-insert-consistency-graphs: Wrong type argument:
    CB> number-or-marker-p, nil

Hi, I've hit the same error.  It was introduced in commit
f471768a54d8921ff383516af6a605adc061af30 -- if all-done-dates is nil
(i.e. a new habit is introduced), it signals an error.

    CB> ----- Begin debugger output --

    CB> Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil)
    CB>   (org-habit-build-graph (737610 1 737613 4 nil ".+") (24292 37530
    CB> 669050 863000) (24320 16922 669050 863000) (24329 31898 669050
    CB> 863000))
    CB>   (org-habit-insert-consistency-graphs)
    CB>   (org-agenda-finalize)
    CB>   (org-agenda-list nil)
    CB>   (funcall-interactively org-agenda-list nil)
    CB>   (call-interactively org-agenda-list)
    CB>   (org-agenda nil)
    CB>   (funcall-interactively org-agenda nil)
    CB>   (call-interactively org-agenda nil nil)
    CB>   (command-execute org-agenda)

    CB> ----- End debugger output --

    CB> The error does not occur with the 'built-in' Org mode version 9.3 for
    CB> emacs-27.

    CB> Best wishes,

    CB> Colin.


    CB> Colin Baxter
    CB> URL: http://www.Colin-Baxter.com

Re: Habit error

[Marco Wahl]

Hello Colin,

Colin Baxter <m43cap@yandex.com> writes:
> With the latest pull of org-mode I now find habits are not displayed
> correctly in agenda. The graph bar is missing, with the error
>
> org-habit-insert-consistency-graphs: Wrong type argument:
> number-or-marker-p, nil

I guess this was due to my attempt to fix of the color of the first done
date for a habit. Sorry for any inconvenience.

Didn't check the case when no done dates are available. I hope that's
been the issue.

Thanks for reporting. Please check again with the latest from the repo.


Best regards,
-- Marco

Re: Habit error

[Colin Baxter]

Hello Marco,
>>>>> Marco Wahl <marcowahlsoft@gmail.com> writes:

    > Hello Colin, Colin Baxter <m43cap@yandex.com> writes:
    >> With the latest pull of org-mode I now find habits are not
    >> displayed correctly in agenda. The graph bar is missing, with the
    >> error
    >> 
    >> org-habit-insert-consistency-graphs: Wrong type argument:
    >> number-or-marker-p, nil

    > I guess this was due to my attempt to fix of the color of the
    > first done date for a habit. Sorry for any inconvenience.

    > Didn't check the case when no done dates are available. I hope
    > that's been the issue.

    > Thanks for reporting. Please check again with the latest from the
    > repo.

Yes, commit 5427a7 seems to fix the problem. My habits are displaying as
they should. Thanks.

Best wishes,

Colin.




Colin Baxter
URL: http://www.Colin-Baxter.com

Re: Habit error

[Colin Baxter]

>>>>> Milan Zamazal <pdm@zamazal.org> writes:

>>>>> "CB" == Colin Baxter <m43cap@yandex.com> writes:
    CB> Hello, With the latest pull of org-mode I now find habits are
    CB> not displayed correctly in agenda. The graph bar is missing,
    CB> with the error

    CB> org-habit-insert-consistency-graphs: Wrong type argument:
    CB> number-or-marker-p, nil

    > Hi, I've hit the same error.  It was introduced in commit
    > f471768a54d8921ff383516af6a605adc061af30 -- if all-done-dates is
    > nil (i.e. a new habit is introduced), it signals an error.

Thanks for the information - it's good to know. The issue seems now to
be fixed in the latest pull.

Best wishes,

Colin.


Colin Baxter
URL: http://www.Colin-Baxter.com