From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id +AZpLtWHSF+WVAAA0tVLHw (envelope-from ) for ; Fri, 28 Aug 2020 04:28:05 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id oOktKtWHSF+gDQAAbx9fmQ (envelope-from ) for ; Fri, 28 Aug 2020 04:28:05 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D015F9404CA for ; Fri, 28 Aug 2020 04:28:04 +0000 (UTC) Received: from localhost ([::1]:41514 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBVze-00081b-2Y for larch@yhetil.org; Fri, 28 Aug 2020 00:28:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47546) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBVzI-00081G-OH for emacs-orgmode@gnu.org; Fri, 28 Aug 2020 00:27:40 -0400 Received: from pb-smtp21.pobox.com ([173.228.157.53]:59703) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBVzF-0003PL-WB for emacs-orgmode@gnu.org; Fri, 28 Aug 2020 00:27:39 -0400 Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 7D992F93F0 for ; Fri, 28 Aug 2020 00:27:35 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=kthIjTOtHlURnwTQ9LUkmO4zHHw=; b=STrXa6 xZs/J+Ys9z/+MpFtTPqQxM7xcImGGF+TeK5NRxjziLiZmEqVSFjuLituKX8d8ukO mIjzYxoH6lwG1mJ6wpjSC0kzZCVlOCKYQlFuHYdaJ3OntwRKe6+pqzqf93MiWfCV mFgBVatGpm/3ZTLixpd5bZBk/6TXcQ/G0jY/M= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 644FCF93EF for ; Fri, 28 Aug 2020 00:27:35 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=ZfowKYZgT4eMRayZd9bVSfUaLSasv/ydwI2q7Op4rRA=; b=ysZeY5qOwi3Ixdx3H0TzGzUvSkZyVGk33xAoX5iO9hzmO7mgGfp/6zvXqTXyBR0W305Yp43cGv+aDlwCnojEQ0jAXLMJOU6XHVAefkSlSvmev5MZdJhL0CuFVrvPXUKsffqzPSKNMmRB6wptocwGevu+VIbnYBm8VSOrMnnVybM= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id D6781F93ED for ; Fri, 28 Aug 2020 00:27:32 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: emacs-orgmode@gnu.org Subject: Re: new feature for consideration: other-tab for org-agenda-window-setup In-Reply-To: <87imd33mys.fsf@ucl.ac.uk> References: <87eentqsws.fsf@ucl.ac.uk> <87k0xlm48z.fsf@kyleam.com> <871rjsquwy.fsf@ucl.ac.uk> <878se0qs4o.fsf@kyleam.com> <87imd33mys.fsf@ucl.ac.uk> Date: Fri, 28 Aug 2020 00:27:29 -0400 Message-ID: <877dtjtmxa.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: CAB0673E-E8E6-11EA-B39D-843F439F7C89-24757444!pb-smtp21.pobox.com Received-SPF: pass client-ip=173.228.157.53; envelope-from=kyle@kyleam.com; helo=pb-smtp21.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/28 00:27:35 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=STrXa6 x; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=ysZeY5qO; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: 0.29 X-TUID: bVNW/KATd3lC Eric S Fraga writes: > Dear all, > > Please see attached for a new version of my changes for adding > 'other-tab as an option for org-agenda-window-setup. > > I think I've addressed all your comments, Kyle, but any more are > welcome. It would be good if somebody who is using an older version of > Emacs, i.e. pre 27.1, could test the error handling: set > org-agenda-window-setup to 'other-tab and see if it fails properly. I > only have v28.x on my systems! > > On v28.x, it seems to be working fine. Thanks for the updated patch. I've tested it on 26.3 as well as the Emacs master branch. > @@ -3769,6 +3776,10 @@ FILTER-ALIST is an alist of filters we need to apply when > (org-switch-to-buffer-other-window abuf)) > ((eq org-agenda-window-setup 'other-frame) > (switch-to-buffer-other-frame abuf)) > + ((eq org-agenda-window-setup 'other-tab) > + (if (fboundp 'switch-to-buffer-other-tab) > + (switch-to-buffer-other-tab abuf) > + (user-error "Your version of Emacs does not have tab bar support."))) Sorry, I've got another consistency/style nit-pick for you: the convention is to omit the trailing period from error messages. (No need to resend for that. I'll plan to adjust when applying.) I'll let this sit for another day to see if other comments come in.