From: Kyle Meyer <kyle@kyleam.com>
To: emacs-orgmode@gnu.org
Subject: Re: new feature for consideration: other-tab for org-agenda-window-setup
Date: Fri, 28 Aug 2020 00:27:29 -0400 [thread overview]
Message-ID: <877dtjtmxa.fsf@kyleam.com> (raw)
In-Reply-To: <87imd33mys.fsf@ucl.ac.uk>
Eric S Fraga writes:
> Dear all,
>
> Please see attached for a new version of my changes for adding
> 'other-tab as an option for org-agenda-window-setup.
>
> I think I've addressed all your comments, Kyle, but any more are
> welcome. It would be good if somebody who is using an older version of
> Emacs, i.e. pre 27.1, could test the error handling: set
> org-agenda-window-setup to 'other-tab and see if it fails properly. I
> only have v28.x on my systems!
>
> On v28.x, it seems to be working fine.
Thanks for the updated patch. I've tested it on 26.3 as well as the
Emacs master branch.
> @@ -3769,6 +3776,10 @@ FILTER-ALIST is an alist of filters we need to apply when
> (org-switch-to-buffer-other-window abuf))
> ((eq org-agenda-window-setup 'other-frame)
> (switch-to-buffer-other-frame abuf))
> + ((eq org-agenda-window-setup 'other-tab)
> + (if (fboundp 'switch-to-buffer-other-tab)
> + (switch-to-buffer-other-tab abuf)
> + (user-error "Your version of Emacs does not have tab bar support.")))
Sorry, I've got another consistency/style nit-pick for you: the
convention is to omit the trailing period from error messages. (No need
to resend for that. I'll plan to adjust when applying.)
I'll let this sit for another day to see if other comments come in.
next prev parent reply other threads:[~2020-08-28 4:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 16:21 new feature for consideration: other-tab for org-agenda-window-setup Eric S Fraga
2020-08-26 16:28 ` Eric S Fraga
2020-08-26 22:28 ` Kyle Meyer
2020-08-27 9:50 ` Eric S Fraga
2020-08-27 10:51 ` Kyle Meyer
2020-08-27 19:31 ` Eric S Fraga
2020-08-28 4:27 ` Kyle Meyer [this message]
2020-08-29 12:07 ` Kyle Meyer
2020-08-31 13:09 ` Eric S Fraga
2020-09-03 10:16 ` Bastien
2020-09-03 12:29 ` Bastien
2020-09-03 21:26 ` Eric S Fraga
2020-09-04 7:06 ` Bastien
2020-09-04 7:50 ` Eric S Fraga
2020-09-03 21:28 ` Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dtjtmxa.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).