From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id At6QKIlBU18xHwAA0tVLHw (envelope-from ) for ; Sat, 05 Sep 2020 07:43:05 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id kGshJIlBU19eLAAAB5/wlQ (envelope-from ) for ; Sat, 05 Sep 2020 07:43:05 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 43D909404CA for ; Sat, 5 Sep 2020 07:43:05 +0000 (UTC) Received: from localhost ([::1]:55622 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kESqm-0005AZ-9E for larch@yhetil.org; Sat, 05 Sep 2020 03:43:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58142) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kESqS-0005AS-GJ for emacs-orgmode@gnu.org; Sat, 05 Sep 2020 03:42:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59667) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kESqR-0003A8-0Y; Sat, 05 Sep 2020 03:42:43 -0400 Received: from [2a01:e35:2fe1:f780:68c6:8f4c:dae1:2381] (port=38762 helo=guerry) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1kESqQ-0008W2-Mq; Sat, 05 Sep 2020 03:42:42 -0400 Received: by guerry (Postfix, from userid 1000) id 8AE421A60D46; Sat, 5 Sep 2020 09:42:41 +0200 (CEST) From: Bastien To: Kyle Meyer Subject: Re: [PATCH] goto: Avoid invoking org-mode for outline navigation Organization: GNU References: <87tv02vy5r.fsf@kyleam.com> <87mu5u5962.fsf@localhost> <87r1v6vwis.fsf@kyleam.com> <87d06owuqo.fsf@kyleam.com> Date: Sat, 05 Sep 2020 09:42:41 +0200 In-Reply-To: <87d06owuqo.fsf@kyleam.com> (Kyle Meyer's message of "Thu, 28 May 2020 04:26:07 +0000") Message-ID: <877dt88ya6.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vladimir Nikishkin , emacs-orgmode , Ihor Radchenko Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: dsaOht4SLP7L Hi Kyle, Kyle Meyer writes: > Kyle Meyer writes: > >> Ihor Radchenko writes: >> >>> Is there even a need to call the whole (org-mode). The new buffer is >>> an indirect buffer. It should already have org-mode activated (at least, >>> we can check for it and not call (org-mode) unnecessarily). If we just >>> want to reset initial visibility, (org-overview) is already doing the >>> job of (org-set-startup-visibility) from (org-mode). >> >> Hmm, thanks for taking a step back. It does seem like the org-mode call >> should be unnecessary. (I haven't tried yet.) > > Based on light testing, dropping the org-mode call doesn't seem to break > anything. I don't use the outline interface to org-goto, so it'd be > appreciated if anyone who does could try it out and see if anything > feels off. I tested the patch and M-x org-goto RET and things run fine here. I applied your patch against maint. Thanks! -- Bastien