emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: Kyle Meyer <kyle@kyleam.com>
Cc: Vladimir Nikishkin <lockywolf@gmail.com>,
	emacs-orgmode <emacs-orgmode@gnu.org>,
	Ihor Radchenko <yantar92@gmail.com>
Subject: Re: [PATCH] goto: Avoid invoking org-mode for outline navigation
Date: Sat, 05 Sep 2020 09:42:41 +0200	[thread overview]
Message-ID: <877dt88ya6.fsf@gnu.org> (raw)
In-Reply-To: <87d06owuqo.fsf@kyleam.com> (Kyle Meyer's message of "Thu, 28 May 2020 04:26:07 +0000")

Hi Kyle,

Kyle Meyer <kyle@kyleam.com> writes:

> Kyle Meyer writes:
>
>> Ihor Radchenko writes:
>>
>>> Is there even a need to call the whole (org-mode). The new buffer is
>>> an indirect buffer. It should already have org-mode activated (at least,
>>> we can check for it and not call (org-mode) unnecessarily). If we just
>>> want to reset initial visibility, (org-overview) is already doing the
>>> job of (org-set-startup-visibility) from (org-mode).
>>
>> Hmm, thanks for taking a step back.  It does seem like the org-mode call
>> should be unnecessary. (I haven't tried yet.)
>
> Based on light testing, dropping the org-mode call doesn't seem to break
> anything.  I don't use the outline interface to org-goto, so it'd be
> appreciated if anyone who does could try it out and see if anything
> feels off.

I tested the patch and M-x org-goto RET and things run fine here.

I applied your patch against maint.

Thanks!

-- 
 Bastien


      reply	other threads:[~2020-09-05  7:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-27  2:59 Bug: why does org-goto call org-latex-preview? Vladimir Nikishkin
2020-05-27  3:45 ` Kyle Meyer
2020-05-27  3:49   ` Ihor Radchenko
2020-05-27  4:20     ` Kyle Meyer
2020-05-28  4:26       ` [PATCH] goto: Avoid invoking org-mode for outline navigation Kyle Meyer
2020-09-05  7:42         ` Bastien [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dt88ya6.fsf@gnu.org \
    --to=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=kyle@kyleam.com \
    --cc=lockywolf@gmail.com \
    --cc=yantar92@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).