emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: emacs-orgmode@gnu.org
Subject: pcase failure with Emacs 24 (was Emacs version for Org 9.4?)
Date: Tue, 15 Sep 2020 23:39:15 -0400	[thread overview]
Message-ID: <877dsu75lo.fsf@kyleam.com> (raw)
In-Reply-To: <87pn6n5u13.fsf@wi.uni-muenster.de>

Jens Lechtenboerger writes:

> Hi there,
> if I open an Org file on
> “GNU Emacs 24.5.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of
> 2017-09-12 on hullmann, modified by Debian”
> I get this error (which I don’t know how to debug):
> Eager macro-expansion failure: (wrong-type-argument listp :pcase--succeed)
> In ORG-NEWS, I only found that “Emacs 24.4 or above is suggested.”
> Did that change?

No, it didn't.

It is pretty tricky to debug, but the failure starts with 4a27b67fd
(org-element: Fix property drawers parsing, 2020-04-22).  As far as I
can see, the pattern introduced there is perfectly valid and should be
compatible with Emacs 24.  I'd _guess_ this is a pcase bug in Emacs 24,
particularly the one fixed by 528872c5f8 (bug#18554, 2014-09-27), but I
didn't make an effort to try to understand that commit.

Interestingly, the error goes away if I just swap the elements in the
pcase (and ...) pattern added by that commit.  Dunno, but if that clears
up the failure on your end as well, I don't see any reason to not make
that change.

diff --git a/lisp/org-element.el b/lisp/org-element.el
index a693cb68d..755de8661 100644
--- a/lisp/org-element.el
+++ b/lisp/org-element.el
@@ -4324,7 +4324,7 @@ (defsubst org-element--next-mode (mode type parent?)
   (if parent?
       (pcase type
 	(`headline 'section)
-	((and `section (guard (eq mode 'first-section))) 'top-comment)
+	((and (guard (eq mode 'first-section)) `section) 'top-comment)
 	(`inlinetask 'planning)
 	(`plain-list 'item)
 	(`property-drawer 'node-property)

  parent reply	other threads:[~2020-09-16  3:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-15  8:22 Emacs version for Org 9.4? Jens Lechtenboerger
2020-09-15  9:46 ` Jeremie Juste
2020-09-15 10:57   ` Jens Lechtenboerger
2020-09-16  3:39 ` Kyle Meyer [this message]
2020-09-16  5:40   ` pcase failure with Emacs 24 (was Emacs version for Org 9.4?) Jens Lechtenboerger
2020-09-17  1:56     ` Kyle Meyer
2020-09-17 15:42       ` Kaushal Modi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dsu75lo.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).