From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 4HWLFL/DzV9KJAAA0tVLHw (envelope-from ) for ; Mon, 07 Dec 2020 05:55:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id evpWEL/DzV9maAAAbx9fmQ (envelope-from ) for ; Mon, 07 Dec 2020 05:55:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 33056940363 for ; Mon, 7 Dec 2020 05:55:08 +0000 (UTC) Received: from localhost ([::1]:43276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1km9UI-0003vg-F2 for larch@yhetil.org; Mon, 07 Dec 2020 00:55:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37094) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1km9TY-0003v1-Vp for emacs-orgmode@gnu.org; Mon, 07 Dec 2020 00:54:21 -0500 Received: from out0.migadu.com ([2001:41d0:2:267::]:12096) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1km9TW-0006Pz-1B for emacs-orgmode@gnu.org; Mon, 07 Dec 2020 00:54:20 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1607320499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NkIhIhKVI2XVZ49iBETcrg6lScrAMhJKtCGDdQGwzzY=; b=fYUT/D7r/pdaKTFKmZIwcraATmWtDqcazeeEjHRHJ6DvhndJtyeumidFt/dSRlKK8hmfgP wbs4Efg8cF1aeqMt452GArVNZ9w298C5ZJin2zVKLpQLrI73c6f8mUhPd6NNWULdPZeP6R w9IWbx5LFGw+GRfFQqO6NqtNcP6CPPXHnfusl/LVoFyoqzhYA2Onm06QGWYz2rgrNemRPE cbwHe8OOF5PSRoEUlO0O+0siEdy1djIWRuMREFq/hnjsXoOSOl48MztCydxAqfQRv+KPue pIrjbSkH9QAC7W3GYYR94pOL+q9do+T0cmE7K8w3OrUfGfF3apYQNkrB6Mx/BQ== From: Kyle Meyer To: Ferdinand Pieper Subject: Re: [PATCH] Persistently save downloaded inline remote images In-Reply-To: <87blhosdw3.fsf@ims.uni-hannover.de> References: <87blhosdw3.fsf@ims.uni-hannover.de> Message-ID: <877dpu40vw.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Auth-User: kyle@kyleam.com Date: Mon, 07 Dec 2020 05:54:59 GMT Received-SPF: pass client-ip=2001:41d0:2:267::; envelope-from=kyle@kyleam.com; helo=out0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jack Kamm , emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.30 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=kyleam.com header.s=key1 header.b=fYUT/D7r; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 33056940363 X-Spam-Score: -1.30 X-Migadu-Scanner: ns3122888.ip-94-23-21.eu X-TUID: MgXdxpxTZY+d Thanks for the patch, and sorry about the slow response. Ferdinand Pieper writes: > Currently remote images are downloaded upon each display. As most of > the time the images do not change in between redisplays, we can > instead buffer the images locally and only update the local copy when > the remote image is updated. Hmm, I'm guessing this was left as a simple download given that there is also a `cache' option that keeps the image around in a separate buffer. Does that value help for your use case? Jack, as the author of the org-display-remote-inline-images commit, what do you think about this patch?