From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 2K/fELjU0WBZeQAAgWs5BA (envelope-from ) for ; Tue, 22 Jun 2021 14:16:56 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 4PZnDLjU0WA8VAAAB5/wlQ (envelope-from ) for ; Tue, 22 Jun 2021 12:16:56 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8862C22B3C for ; Tue, 22 Jun 2021 14:16:55 +0200 (CEST) Received: from localhost ([::1]:46744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lvfKo-0002dU-JI for larch@yhetil.org; Tue, 22 Jun 2021 08:16:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56140) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvfIu-0001St-Ik for emacs-orgmode@gnu.org; Tue, 22 Jun 2021 08:14:56 -0400 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:45648) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lvfIs-0004iK-IK for emacs-orgmode@gnu.org; Tue, 22 Jun 2021 08:14:56 -0400 Received: by mail-ed1-x52f.google.com with SMTP id r7so23294515edv.12 for ; Tue, 22 Jun 2021 05:14:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:in-reply-to:references:cc:date:message-id :mime-version; bh=4jZ5O8WrNZOtaBcvqMwTKx6jtSGGCciVNij2492f8ro=; b=uHuporN8TA23+jK29Vbntmtik1rz/sk6C3kwblBu6O9o8X/64k8qgLmrvtbRln1fkK aYof8Fz0OkLiogIL4p1panQ0x/ehvTDXqLtFRbwPNgc6NwuY95SWD6CS0yDEWHx2xoMe Zfd9w0bTu9bgNc2JQ/ynSqBXgyhNU2mgShDMFxEFjPT+oPN9gt4RvxVW8hrIc1egvmzt 5PgPdqhAh3YVdVfuABZmog7sCFmDgncZMbSpzOKXYegZYXaWp8abyAs5qrZYgEM8laTw +ETVkmGXDt3chSKAND2lTrqIC93VoV4nArBJJkuulcKwSImx7iEGkUG/hoklsNBaMXPj yKuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:cc:date :message-id:mime-version; bh=4jZ5O8WrNZOtaBcvqMwTKx6jtSGGCciVNij2492f8ro=; b=hSVDGm5pmjQNHCSGvjNdUmylH2jnWpmGLC3kpZQwkRjtsWk9f8iOncofM/g0W/tIC7 9WRO0Twh6CE/cNSBhtdNi92I3vozOmTeKgo2zRJokGpPEz1QrSPsQjsO/S232wu4n0g5 NknYg6Ystf0ZvC856BPhO0QqEVF1Sdyqp9aFEZbcpkmPLKulJAaRJx0lDuEzjt+El7A4 d+6DyyTj+C9QResoX8ldV1UGuFcB7FqjJNQrOvTwHhGO3bm0p/rJqRZI35Wf0Ku9JjOB zhLLlq5hJMCDtOg5r9N5VLXJ7KP1wgzb8sUjLt0gcZjDOBqxpgPCMeIMh5eEIH7g6wQr sADA== X-Gm-Message-State: AOAM531QSbiUNh/o4pP6xhMYXIwWJYLEmckaT1o6WmOOnGlRzXKdeiP1 RN9CWOi+rdO8LV37dzwnxZk= X-Google-Smtp-Source: ABdhPJz0t2gnr2R88smlXj4XEza3HbZ/SGTTpk25PxR992aEpzvwkv4n319Ya+orMYdkjwG1RE+NVA== X-Received: by 2002:a05:6402:10cc:: with SMTP id p12mr4553120edu.328.1624364091996; Tue, 22 Jun 2021 05:14:51 -0700 (PDT) Received: from localhost ([158.255.2.9]) by smtp.gmail.com with ESMTPSA id f18sm5029530edv.95.2021.06.22.05.14.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jun 2021 05:14:51 -0700 (PDT) From: Ihor Radchenko To: "Tory S. Anderson" Subject: Re: Bug: clock-in from org-agenda freezes thread when enforce + todo keywords [9.4.4 (release_9.4.4 @ /usr/local/share/emacs/28.0.50/lisp/org/)] In-Reply-To: <87h7i52tca.fsf@byu.edu> References: <87h7i52tca.fsf@byu.edu> X-Woof-Patch: t Date: Tue, 22 Jun 2021 20:14:53 +0800 Message-ID: <877dim3xky.fsf@localhost> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::52f; envelope-from=yantar92@gmail.com; helo=mail-ed1-x52f.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1624364215; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=4jZ5O8WrNZOtaBcvqMwTKx6jtSGGCciVNij2492f8ro=; b=gq+5dWlntvs+R6G7WFA8oiWWYjwF38BliZr8QcYBKjInqyvw2jZSWmzrhwo2HoLZVLImGI pT5sEY4blpnq9PXdx0aISBvuMeMLl/42+G8f7wmBZv5YcGjrNMNrli1Ba+8joOrk9qvvPT OdrUO39bkziQIxmzj/D889mBJLrVu9YQwfYq7AFKKJDj7dn9BeDTht0HsdJTZq57dI22BX M0HsOBkUScrObgoSyL7545be48Ahxmm1EJTwZm2wu3CJ+PckmJV+sf5qwzcyXpFjEOKGyy LsLkMEgcSuJL2Yc2y6Gh5iJH/MTDBuSGIUraeg8AVU3hs/jBhEOqiTxXx+UDiw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1624364215; a=rsa-sha256; cv=none; b=GOEdNVDBzAVDpz5ek85RwLlGn2VQIl+Q42aNPmbIbFCt7nF2TDd6+TXhIEWlEHfRugYMrR PaZnFM8S9/ngxKvvOwxgslY66rVxeJtIlMk8gYmlEYc0JNsREh1lSp6+6w39raYpqHEkqg hqQ0OBZTpAb3fZu0I6p9Z2V1y/ze/809eE2c0pVr2ixITuM9ydRj7fNIGbOFw26dQnu1ud QPQCEK7mVr5DqYih/F5gD7Cv1nz/3uGQEWZptDen5mMLkvXYf9q3YDmOse29UOgtRnJLei pmfyttp3TQiIJ92iEvFNJvhxfnMaGNOvtcCf4QiJ3ksdLQDrO5SscyyeEOp1hQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=uHuporN8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.62 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=uHuporN8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 8862C22B3C X-Spam-Score: -2.62 X-Migadu-Scanner: scn0.migadu.com X-TUID: VRrzJTbsrCu9 --=-=-= Content-Type: text/plain webdev@toryanderson.com (Tory S. Anderson) writes: > Steps to reproduce: > > 1. load emacs with the use-package declaration below > 2. visit =M-x org-agendaa3. Clock in to the "Parent" item on the agenda by highlighting it and doing =C-c C-x -- thread will freeze indefinitely, although in toy example you can break free with C-g Confirmed The patch is attached. Best, Ihor --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Avoid-infinite-loop-in-org-agenda-dim-blocked-tasks.patch >From 5c4a699e5a8d9ce6045d0ce710dcf14b9a92d2d8 Mon Sep 17 00:00:00 2001 Message-Id: <5c4a699e5a8d9ce6045d0ce710dcf14b9a92d2d8.1624364038.git.yantar92@gmail.com> From: Ihor Radchenko Date: Tue, 22 Jun 2021 20:10:16 +0800 Subject: [PATCH] Avoid infinite loop in org-agenda-dim-blocked-tasks * lisp/org-agenda.el (org-agenda-dim-blocked-tasks): When the blocked task is the last line in agenda buffer and no trailing newline is present, (move-beginning-of-line 2) would not move the point causing infinite loop. Now, such case is handled correctly. --- lisp/org-agenda.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index 44acd035a..b5fc0179a 100644 --- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -4107,7 +4107,9 @@ (defun org-agenda-dim-blocked-tasks (&optional _invisible) (overlay-put ov 'face 'org-agenda-dimmed-todo-face)) (when invisible (org-agenda-filter-hide-line 'todo-blocked))) - (move-beginning-of-line 2)))) + (if (= (point-max) (line-end-position)) + (goto-char (point-max)) + (move-beginning-of-line 2))))) (when (called-interactively-p 'interactive) (message "Dim or hide blocked tasks...done"))) -- 2.31.1 --=-=-=--