emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "András Simonyi" <andras.simonyi@gmail.com>
Cc: emacs-orgmode list <emacs-orgmode@gnu.org>, Timothy <tecosaur@gmail.com>
Subject: Re: [wip-cite-new] experimental citeproc-el based activation processor
Date: Tue, 22 Jun 2021 20:08:58 +0200	[thread overview]
Message-ID: <877dilhiv9.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAOWRwxDyXTw317XH_vYea-ec2LFzEU_RyOZJvuaX9so1Bg5zYA@mail.gmail.com> ("András Simonyi"'s message of "Tue, 15 Jun 2021 09:12:21 +0200")


András Simonyi <andras.simonyi@gmail.com> writes:

>> - As suggested by Bruce D'Arcus, we might move `org-cite-get-boundaries'
>>   in `oc.el' proper, since it is also used elsewhere (at least in
>>   "oc-basic.el").
> sure, it makes more sense there, especially because I took the
> fragment from your code IIRC (apologies for the lack of explicit
> attribution)

No problem: I stole it back from you! ;) I added `org-cite-boundaries'
to "oc.el", so your library can make use of it (after a rebase).

>> - Nitpick: (car element) => (org-element-type element)
> I was actually wondering about this when I wrote the code and if I may
> nitpick on the nitpick, I find the documentation a bit confusing in
> this respect. If the list representation is meant to be
> internal/private only (I guess that is the case), then maybe this
> should be more explicit in the docstrings, because now the docstring
> of `org-element-context' says
> "Return smallest element or object around point.
> Return value is a list like (TYPE PROPS) [...]"
> Omitting the second part or having something like "Internally, return
> value is [...]" would go a long way toward conveying the message that
> one shouldn't rely on the list representation.

It's not that one shouldn't rely on the list representation, but the
expressiveness of `car' is very low, whereas `org-element-type' is
explicit. I was merely suggesting to lean towards expressiveness here.

Nicolas Goaziou

      reply	other threads:[~2021-06-22 18:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-12 11:30 [wip-cite-new] experimental citeproc-el based activation processor András Simonyi
2021-06-12 14:46 ` Nicolas Goaziou
2021-06-12 15:43   ` Timothy
2021-06-12 15:45     ` Timothy
2021-06-12 16:03       ` Bruce D'Arcus
2021-06-12 19:43       ` Nicolas Goaziou
2021-06-15  7:12         ` András Simonyi
2021-06-22 18:08           ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dilhiv9.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=andras.simonyi@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=tecosaur@gmail.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).