emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Timothy <tecosaur@gmail.com>
To: Ihor Radchenko <yantar92@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [feature proposal] Headline caching via org-element-cache = up to 2.5x performance boost
Date: Sun, 19 Sep 2021 20:39:39 +0800	[thread overview]
Message-ID: <877dfcenze.fsf@gmail.com> (raw)
In-Reply-To: <878rzs7r0c.fsf@localhost>

[-- Attachment #1: Type: text/plain, Size: 1410 bytes --]

Hi  Ihor,

Thanks for clearing up the nature of your patch-y feature request.

>> p.s. I’m marking this as a patch on the tracker, since it is one :P
>
> This is not a real patch. I just separated changes I made in
> org-element.el. Other changes include cache support across Org code and
> tests. In total it looks roughly like:
>
> 12 files changed, 2584 insertions(+), 1140 deletions(-)
>
> However, I did not directly base the patch on master, but rather on
> (hopefully-to-be-merged-at-some-point org-fold branch :’/). I am not too
> interested in porting the patch onto master. At least not until I get
> feedback on parser and API changes.

Righteo, I’ll un-mark this as a patch then 🙂.

>> As someone who tangles massive literate config this sounds like it could make
>> quite a noticeable improvement. To test this, do I need to do anything more than
>> just apply your patch?
>
> Applying the patch will not work. As I said, it is mostly for reference
> to show the changes to parser and API. If you want to test it, you can
> use <https://github.com/yantar92/org>. That repo includes the org-fold
> branch and the new cache implementation.

Ah, I’ve already got a few patches on Org that I’m preparing for sharing on the
ML, so this may make it a bit harder for me. I’ll let you know how I find it if
I do give it a go though.

All the best,
Timothy

  reply	other threads:[~2021-09-19 12:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-19  7:30 [feature proposal] Headline caching via org-element-cache = up to 2.5x performance boost Ihor Radchenko
2021-09-19  9:58 ` Timothy
2021-09-19 11:18   ` Ihor Radchenko
2021-09-19 12:39     ` Timothy [this message]
2021-09-19 12:52       ` Ihor Radchenko
2021-09-25 14:51         ` Bastien
2021-10-17  6:56           ` Ihor Radchenko
2021-10-18  5:07             ` Bastien
2021-10-17  6:57           ` Ihor Radchenko
2021-10-18  7:47             ` Bastien
2021-10-18  8:10               ` Ihor Radchenko
2021-10-18  9:25                 ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dfcenze.fsf@gmail.com \
    --to=tecosaur@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).