emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] ob-R async evaluation
@ 2021-10-05 22:37 Jeremie Juste
  2021-11-18 10:36 ` Timothy
  0 siblings, 1 reply; 2+ messages in thread
From: Jeremie Juste @ 2021-10-05 22:37 UTC (permalink / raw)
  To: Org Mode

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

Hello,

I'm attaching a patch that clean up a bit of non conventional coding
practices (mainly because of my ignorance), in ob-R. These were
initially generating warning during the compilation of org-mode.

The main feature is the use of the defvaralias ess-eval-visibly-p when
the :result output in async evaluation. 

With this change make does not generate any warning for ob-R.el and all
the test of ob-R.el passes, so no significant change for the user.

Best regards,
Jeremie


[-- Attachment #2: 0001-ob-R.el-Patch-4-async-evaluation.patch --]
[-- Type: application/pdf, Size: 4196 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ob-R async evaluation
  2021-10-05 22:37 [PATCH] ob-R async evaluation Jeremie Juste
@ 2021-11-18 10:36 ` Timothy
  0 siblings, 0 replies; 2+ messages in thread
From: Timothy @ 2021-11-18 10:36 UTC (permalink / raw)
  To: Jeremie Juste; +Cc: emacs-orgmode


Hi Jeremie,

Sorry it's taken a while to get to this. I've just gone through your
patch and it looks quite reasonable. I also took the liberty of
fixing the indentation in a few spots and tweaking your commit message.

This has just been pushed as 58db28d.

> I'm attaching a patch that clean up a bit of non conventional coding
> practices (mainly because of my ignorance), in ob-R. These were
> initially generating warning during the compilation of org-mode.

By the way, just letting you know that your mail client declared your
.patch to be a PDF file 😛.
> [2. application/pdf; 0001-ob-R.el-Patch-4-async-evaluation.patch]...

--
Timothy


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-18 10:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-05 22:37 [PATCH] ob-R async evaluation Jeremie Juste
2021-11-18 10:36 ` Timothy

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).