9.6 - hide-drawer-startup option(s?) [9.5.5 (release_9.5.5 @ /usr/local/share/emacs/29.0.50/lisp/org/)]

["Kévin Le Gouguec" <kevin.legouguec@gmail.com>]

Hey Org,

Trying out Emacs 29 and going over ORG-NEWS, this item stands out to me:

> *** A new custom setting =org-hide-drawer-startup= to control initial folding state of drawers

A quick grep for org(-cycle)?-hide-drawer-startup turns this up:

File: etc/ORG-NEWS
 459  27 *** A new custom setting =org-hide-drawer-startup= to control initial folding state of drawers

File: lisp/org-cycle.el
 128  12 (defcustom org-cycle-hide-drawer-startup t
 630  11     (when org-cycle-hide-drawer-startup (org-cycle-hide-drawers 'all))

File: lisp/org.el
4074  20     ("hidedrawers" org-hide-drawer-startup t)
4075  22     ("nohidedrawers" org-hide-drawer-startup nil)

AFAICT those were all introduced in 2022-06-25 "org-cycle.el: New custom
setting `org-cycle-hide-drawer-startup'" (bcfed0f34).  Is the patch
below in order, or have I missed something that makes this all work?

(Haven't actually tried the feature and won't be able to before this
evening; sending this speculatively in case things are as simple as they
look.  Apologies for the noise if not)


diff --git a/etc/ORG-NEWS b/etc/ORG-NEWS
index 67889c0b1..e3b3f802d 100644
--- a/etc/ORG-NEWS
+++ b/etc/ORG-NEWS
@@ -456,7 +456,7 @@ options:
 =:icalendar-scheduled-summary-prefix=,
 =:icalendar-deadline-summary-prefix=
 
-*** A new custom setting =org-hide-drawer-startup= to control initial folding state of drawers
+*** A new custom setting =org-cycle-hide-drawer-startup= to control initial folding state of drawers
 
 Previously, all the drawers were always folded when opening an Org
 file.  This only had an effect on the drawers outside folded
diff --git a/lisp/org.el b/lisp/org.el
index 3018e4d6f..80e44d85a 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -4071,8 +4071,8 @@ After a match, the following groups carry important information:
     ("noptag" org-tag-persistent-alist nil)
     ("hideblocks" org-hide-block-startup t)
     ("nohideblocks" org-hide-block-startup nil)
-    ("hidedrawers" org-hide-drawer-startup t)
-    ("nohidedrawers" org-hide-drawer-startup nil)
+    ("hidedrawers" org-cycle-hide-drawer-startup t)
+    ("nohidedrawers" org-cycle-hide-drawer-startup nil)
     ("beamer" org-startup-with-beamer-mode t)
     ("entitiespretty" org-pretty-entities t)
     ("entitiesplain" org-pretty-entities nil))