From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 6Lu1N0bN02NE0wAAbAwnHQ (envelope-from ) for ; Fri, 27 Jan 2023 14:10:31 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id UKu0NkbN02OcPgEAG6o9tA (envelope-from ) for ; Fri, 27 Jan 2023 14:10:30 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9360E3B43 for ; Fri, 27 Jan 2023 14:10:30 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pLOUF-0006kk-7E; Fri, 27 Jan 2023 08:09:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLOUB-0006kV-RD for emacs-orgmode@gnu.org; Fri, 27 Jan 2023 08:09:43 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLOU9-00013S-OO for emacs-orgmode@gnu.org; Fri, 27 Jan 2023 08:09:43 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 9559E240733 for ; Fri, 27 Jan 2023 14:09:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1674824979; bh=JLnZI4XuPTJmxGV4WY5ElYBtWjHpdMb+lUlAqccCzoI=; h=From:To:Cc:Subject:Date:From; b=hd+5sqnZelXOMOPpKAChAdv/qyN1EINmcHUwAwQzPrQscpI97dYkDrOqSJmbPdJmc 5RM9TTwkZ4S1xcVhccUH9k4tsHAcC5GhlbJdBSw4MdHfiljpMHsO68cNyZ2dmCvGRi fixqFBFCFvwtyBPgJ9xGhjaiKTENOSmKNUJ1Gw8L10gd3WXJd4lcQGLJuesJyKSmq5 vtoe05mL7TBSegqUrPRfXkjynJHRs2gh9yqMGSn4HJd/k6M9GhckLy70QVSzOCAONv wkwCuJ01t0P+bUXeLgBmEqsQ9kW9/DE9Q2brnVEKtG5U354y16BW5gKYJEAm0d4bky XxCMmIIsksD4g== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4P3Hwf2cYxz6tq0; Fri, 27 Jan 2023 14:09:38 +0100 (CET) From: Ihor Radchenko To: Andreas Gerler Cc: Ruijie Yu , emacs-orgmode@gnu.org Subject: Re: [O] [PATCH] ob-eval: display error fix In-Reply-To: <94980226-D29A-4969-8640-1143A1979164@bundesbrandschatzamt.de> References: <94980226-D29A-4969-8640-1143A1979164@bundesbrandschatzamt.de> Date: Fri, 27 Jan 2023 13:10:11 +0000 Message-ID: <877cx886oc.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674825030; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=fO6Vx70yAqjQEu1/yPk4tJNrIHdEnoulEsITsEDFHjE=; b=lgq3Z84TSzQnyHRmqL5YgPompdEXHvA+UMaqJHyuUff4hHB4lUWaRG4xnRGqFgcXG6vunW hqqZLeLw22v5qDRP8BhavpqOy9fmywhZdRTl9m8U0zCqKg9YidDTjsGp8O43Shd1SrqsmX i32BmSz5TlrcnlgC9pR2SxxX7AGLOp9UAC3+Zvc6XU++1X3cQpc5vIxi9So1K/guM5rQgQ dlQojM3kNQHIV5A9X2NA3aufWOCRwjnu8AeOVX9vy406rIwFsfdpHCchwB6N4dbNJJzp8O 1/yj9ynu9HLz2DECKdilIYTx+njw+LIm6wCdH+aJJdsOcvC+nI7Ngf1BGXx7ng== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=hd+5sqnZ; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674825030; a=rsa-sha256; cv=none; b=VIDpUGJeXuIMpZ0g2EbM7t4wV66OTiArBFwMr6nr6xWQnshOTz4r6n85T3hZpVVjvhl/Zp m0IqGJJs+2e9kZWLs3G3zPqbzjREtCfLpEo1CVySNbFqV6lA3VBpIC0FAcS+K3RkgG+I5/ wG7zg7yng7AzhRqsFdK9alWMfXo4sZtuwx709n1xs0YDaSSND6Y0+79NosoCFhShVtAiA6 k73He984aRgaSPy30ucJRv0dyeg9T8XN9ZxdWU4C8C2DgnGQK1LOwYRNtcON7BGUCFRJ51 DqGAIUK4T9j3DTuXl2hCX8IzIaZT1MEqaMU1oDH8ZGn4XsWlyPrIgte8ffU8Kw== Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=hd+5sqnZ; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -8.03 X-Spam-Score: -8.03 X-Migadu-Queue-Id: 9360E3B43 X-TUID: Mo1zarUhYbdE Andreas Gerler writes: > +(defcustom org-babel-eval-error-display-notify nil > + "Display org-babel-eval-errors always or only if exit code is not 0." This docstring is confusing. What will happen if the value is nil? non-nil? I cannot answer these questions by reading the docstring. Also, what is "org-babel-eval-errors"? Symbol? Finally, I do not think that "nil" is a good default here. It is better to display warnings by default and let people disable them only consciously, when needed. Ideally, we may allow the value to be a list of backends where to display/not display the warnings. > + :group 'org-babel > + :version "29.1" Please use :package-version instead. And add the new customization to etc/ORG-NEWS. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at