Re: [PATCH] Avoid crash in `org-file-contents' in case of network failure

[Ihor Radchenko <yantar92@posteo.net>]

Damien Cassou <damien@cassou.me> writes:

> I've signed the FSF copyright agreement in the context of my
> contributions to Emacs. Do I need to do any more paperwork?

No, you don't.
Bastien, could you please check FSF records?

>> I think that it will be a good idea to indicate in the `message' where
>> the error is coming from. The error intercepted by this `condition-case'
>> form will likely be a network error, and it may be unclear to the user
>> which function is failing to make the connection.
>
> I tried to make that a little bit clearer:
>
>   (message "Org could't download \"%s\": %s %S" file (car error) (cdr
>   error))
>
> Do you want me to explicitly refer to the current function name?

Should be good enough.

I think you forgot to attach the updated patch :)

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>