From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id +NltJJrcGmQ2KAEASxT56A (envelope-from ) for ; Wed, 22 Mar 2023 11:46:50 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 8IhYJJrcGmQd9wAAauVa8A (envelope-from ) for ; Wed, 22 Mar 2023 11:46:50 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2AEB62CD91 for ; Wed, 22 Mar 2023 11:46:50 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pevz0-0003fd-U2; Wed, 22 Mar 2023 06:46:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pevyp-0003eP-EG for emacs-orgmode@gnu.org; Wed, 22 Mar 2023 06:46:07 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pevyn-0005FC-30 for emacs-orgmode@gnu.org; Wed, 22 Mar 2023 06:46:06 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 468BD240317 for ; Wed, 22 Mar 2023 11:46:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1679481963; bh=SZJnAaFm6XGbAoYYzKxcRYugDoG/Yoy1J0uUCEmYRNg=; h=From:To:Cc:Subject:Date:From; b=EgZAjSKznNuFXuA+7/cezHkqFD5nP1p2xpAe6PrQJ8dwznIoQzgknQ4oR9TxvtcsN HpvhQ6F+Iv88gBSLw2/56XkQf0pXRizsWwXeGUuxD9BHpqrXor+kmoB+lHb1v5v7EJ kKvVo8JR5lnT+wU5bmVZani8y77oZtL9zV/aQBo3qOIZjvWOZ4IS+AUp3FsH9wyyoH LjvVL8FOpW62pTvrOQ8i/6c2bJ9WNWdiazvDCHI/nGz/8LVsyNUX7E2/mYCrTug2lb VyB5gbsS9OEetBj0iGH55TRMAs8ffHxTJeCxNZXXXUzszmjFT/6ubTUh6MHNw2Xjk0 92JF79f9eTAqQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PhQB24W9Jz6tpJ; Wed, 22 Mar 2023 11:46:02 +0100 (CET) From: Ihor Radchenko To: Daniel Kraus Cc: emacs-orgmode@gnu.org Subject: Re: [patch] ob-clojure: Fix results output In-Reply-To: <87zg88eaib.fsf@kraus.my> References: <87mt4m53qj.fsf@kraus.my> <87pm9gyebl.fsf@localhost> <877cvkhh9d.fsf@kraus.my> <874jqno6hw.fsf@localhost> <873567h2kk.fsf@kraus.my> <87y1nzflur.fsf@kraus.my> <87v8j2qpsq.fsf@localhost> <87ttymfe9i.fsf@kraus.my> <87y1nxt2v2.fsf@localhost> <87edplyxj5.fsf@localhost> <87zg88eaib.fsf@kraus.my> Date: Wed, 22 Mar 2023 10:48:05 +0000 Message-ID: <877cv9oye2.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1679482010; a=rsa-sha256; cv=none; b=HP7h7I/pSamWNHfz8+S1RObr78iWie6UhNy6kDCsohmemrebMKHj/00ovlYfgnJmmtAVM2 aI6/auEOWMUpxXgpI8jzjnyi2iBZaQCDh8SNZ8PrFEvJsxPCQKjklZKu0adonAg1F+2F+J fJQUO29mh/h3xZElJn9Y7MsSTCKRMn/vYZ98oh/MjfH51TySl4/JQrxck8axvAS3f1VO7L jTn6k3CWER5dnCdg+UFQM60UcP9wh10XOjJqIx/TpVCqtXaYbyiAuVsRDRM8QXJChTHzSA 61QQYNkLR6yy3PlndHmFM00Wi8x+06Y2hix/lfTvfmPuLhYB0LQ9LOQsCEttJA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=EgZAjSKz; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1679482010; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=pu2nQEitb4k837EifNNN/rB3fhHIcQsjdEx8KICc20s=; b=XA+5s8Bj1MZJIetQYfsWKYo/o1OhJPGAz5nhY74LhDhPvxAM+TX6KTKzjlJoA+i+7ud7zo od7dgKv00tK2zF4UxEHTSmA3rhr1l59dnic0OH+LLcQj3Rc1VJ/ZF9yYh0ci7C2WQIlqSV dfbO+YVyJHCov8Aw9x/dGVhoIFIHu7SL6SLiGsWl3TAetti5gFVLchz+dUIbaXh3Co99Kc da0Pak/inSJ8eESPTrtmRQYhWtbWTNCUYkb7u/k5EvSVvzJGl08fkrIoazv3kbXbebzB41 FwKAvhris3UtpIn5KH2Y8wGnLMykEYdvM8/gV79ZugwhiCacBlfXSR4IdQCYrA== X-Migadu-Spam-Score: -4.77 X-Spam-Score: -4.77 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=EgZAjSKz; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-Migadu-Queue-Id: 2AEB62CD91 X-Migadu-Scanner: scn1.migadu.com X-TUID: jHpvQqrlSnxi Daniel Kraus writes: > Ihor Radchenko writes: > >> I note that we now have a new compiler warning after your changes: >> =E2=9B=94 Warning (comp): ob-clojure.el:268:45: Warning: Unused lexical = argument =E2=80=98params=E2=80=99 >> >> May you please take a look? >> If the function argument is really unused, replace it with _ in >> `ob-clojure-eval-with-cider'. > > Ups, sorry. > Before `params` was only used to receive the :target parameter if it's a = cljs or clj > block. But that's now just a regular parameter to the function. > I fixed it with a _ prefix. Now, the docstring appears to be a bit confusing: (defun ob-clojure-eval-with-cider (expanded _params &optional cljs-p) "Evaluate EXPANDED code block with PARAMS using cider. When CLJS-P is non-nil, use a cljs connection instead of clj." It would be useful to mention that PARAMS argument is unused. --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at