From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id MJNeLg+CMmRgPAEASxT56A (envelope-from ) for ; Sun, 09 Apr 2023 11:14:55 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id gPFaLg+CMmSUAgAAauVa8A (envelope-from ) for ; Sun, 09 Apr 2023 11:14:55 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7CA454171E for ; Sun, 9 Apr 2023 11:14:55 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1plR7a-00017D-S9; Sun, 09 Apr 2023 05:14:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plR7Y-00016k-5R for emacs-orgmode@gnu.org; Sun, 09 Apr 2023 05:14:00 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plR7W-0001QX-7Z for emacs-orgmode@gnu.org; Sun, 09 Apr 2023 05:13:59 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 12FB5240029 for ; Sun, 9 Apr 2023 11:13:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1681031636; bh=jSFuEeNdteVq04PfnYuixpQ3k2j6ZDmARxmnemU6z7I=; h=From:To:Cc:Subject:Date:From; b=hY2acHvrGK5t56Lv2Ixf0K2do0eLE2IfSeLk4J7UdcKj8RHAqcJE/uLeZDXtEHo3L VbNari/d4URV2HkSIt6Wc3RiYFPVYBEHujNUjzZZKRWaZUlyNWwLL2iFKesXSma091 uLUiEwOpalrQ+118StYUxwdnhmQAkkpeEa7KAv6lRDewhia6YIPhZu0tDkhDYMQpxx 1Vuz7KKF8eUGuMRKVDQra8YxBR26GRYoOi3m03nMfavY9JzMYL6vTHzdxQ7luQQTU3 rBvFysEwiU3Wb6TtQ27rVPdvUSVBOfxjLG59RvfqC5Yv9D2tNwUs51mLkjZmyICZHT cc/Js5styF6kg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PvRHR4bB2z9rxP; Sun, 9 Apr 2023 11:13:55 +0200 (CEST) From: Ihor Radchenko To: =?utf-8?Q?S=C5=82awomir?= Grochowski Cc: emacs-orgmode@gnu.org Subject: Re: [RFC] [feat] org-colview/org-columns: 'column view' moving rows up/down In-Reply-To: References: <87lej51frx.fsf@gmail.com> <87355ckl7d.fsf@localhost> Date: Sun, 09 Apr 2023 09:16:16 +0000 Message-ID: <877culo1pb.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1681031695; a=rsa-sha256; cv=none; b=jWqBWzugpPgrelT4/Pi6k6ZclNpsFAgxL4SHhzfsL3Oevym+7BS5RmyFXWUO5F6FTMObsJ Pwc5QPgsvPlUXQptMw4zwPldOwPBRIW+Y3krK6i7kRXGhPUxDBt0ZTIqTW4Z0aYlXZygVp EQAIa6g6sTRl08iLJQgu06LKymULz1n+AX2O1YvpuuMyZQwJxgVzsynUSWR5ZK5UhB3fUk DlI28TGkZfdM16p+VBmMcoQEzpP0lELA6MtmTbqYklYnbCsnQ9hAMZoKYaISh8VqIWa2GC BfZZ97wmqara1tCA9VAvUlIRaUAvw9Vubdk+nTPgSb2GIL50CCAMm1cW/Sp4Ww== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=hY2acHvr; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1681031695; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=h8q+HlC09KUgLlhQj4wudLDCFvtWg1o0vY/bBLETNEo=; b=CRCnOmcHvNPd/p0aIj2SaE4/uP8AI5JRmaK34RXZ9XTBkll7I67uvzOvYCAUM9s3o8vgsB 6Ax1DC9RXY41gqhNzvWYSruO/LLtwvXWrK1kqVQjqqQGr4z1h0nfApsbyMvcFH6MMONPkK zfGIhl8qTCDOsPJExzR3Jm7kV6noHhtI8aqp+fSmqUSApDzmbj7ab6ifYeNaNCVahKN1AU /eAookEfFOeMHaiHrthxztdl5zilHWa0+mSrynL4gM3O8rNUKi+FymPVN4OHSjwPE2PlOp BnVmmBi4W/dNhqYC/RuYrAu+fBGxYF7QUZF1+MCk3XIINm6F7KE7fg3JXs2Hlw== X-Migadu-Spam-Score: -4.72 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=hY2acHvr; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Spam-Score: -4.72 X-Migadu-Queue-Id: 7CA454171E X-TUID: GrQVSt+pWyQJ S=C5=82awomir Grochowski writes: > Thank you Ihor for the code review. > Now please help me find everything that can be improved in this patch. I just tried to use the patch using the following test case: 1. Create a new Org file containing * A=20 * B=20 * C=20 ** C1 * D=20 2. C-u C-c C-x C-c 3. M-< 4. M- M- M- M- M- M- M- M- C-c C-c 5. Observe text disappearing and columns being unhighlighted. At the end, the buffer is left with * B >> Finally, I see no records about you copyright assignment status. >> Please take a look at >> https://orgmode.org/worg/org-contribute.html#copyright >> > > Yes, it's my first time. I sent an email to assign@gnu.org, yesterday. Note that they should reply within 5 working days. --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at