Re: [DRAFT PATCH v6] Decouple LANG= and testing (was: Test failure due to LANG)

[Ihor Radchenko <yantar92@posteo.net>]

Ruijie Yu via "General discussions about Org-mode."
<emacs-orgmode@gnu.org> writes:

> Iteration v6.  Everything, other than the French test and the
> batch-non-batch Chinese test, now passes.  I'll look up how to determine
> whether we are in batch mode or not, and slap that onto the expect tag
> for `test-org-clock/clocktable/lang'.  And the French test belongs to
> its own thread, so I won't try to fix it here.

Ideally, we should figure out what is behaving differently in batch mode
and report it upstream. Sometimes, these issues are related to our
misunderstandings of how Emacs works. For example, I had to add
`org-current-text-column' because Org relied on some undocumented (and
changed in recent Emacs versions) behaviour of `current-column'.

> From 59cbb93b9fc221bdc8ee708b05943a245c41ad25 Mon Sep 17 00:00:00 2001
> From: Ruijie Yu <ruijie@netyu.xyz>
> Date: Tue, 25 Apr 2023 22:56:02 +0800
> Subject: [PATCH 2/2] Let org-columns correctly detect string-widths in code

I have no comments on the patch. Looks good to me. Better test coverage
will be also welcome.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>