From: Ihor Radchenko <yantar92@posteo.net>
To: gerard.vermeulen@posteo.net
Cc: Timothy <orgmode@tec.tecosaur.net>,
Emacs orgmode <emacs-orgmode@gnu.org>,
Christian Moe <mail@christianmoe.com>
Subject: Re: [PATCH] ox-html.el: add option to embed SVG for CSS support in SVG
Date: Wed, 07 Jun 2023 09:07:37 +0000 [thread overview]
Message-ID: <877csfej3a.fsf@localhost> (raw)
In-Reply-To: <fd341b330de9fd4ef881c4dc70fb07e6@posteo.net>
gerard.vermeulen@posteo.net writes:
>> This is awkward. To do per-image export adjustments, we usually use
>> export attributes (#+ATTR_HTML: ...). And why "split"?
>
> I do not think that #+ATTR_HTML allows to embed (= copy) the contents
> of an SVG file directly into the HTML page. As far as I understand, it
> adds
> only attributes to HTML elements.
For now, yes. But more generally, Org uses #+ATTR_BACKEND to configure
export. For example, see "13.10.6 Images in LaTeX export".
You may arrange ox-html to handle special #+ATTR_BACKEND: :org-embed t
attribute that will be ignored in `org-html--make-attribute-string' and
checked in your `org-html--embed-svg-p'.
> The "split" is because of similarity with :select_tags and :exclude_tags
> in ox.
> It allows several files to be included in or excluded from embedding.
Makes sense.
>> Please use `org-export-inline-image-p'.
>
> I think that the terminology "inline-image" in ox-html is confusing.
> In ox-html the result of the "inline-image" code is an HTML tag like
>
> <img with attributes inside>
>
> It does not mean that image data is copied inline as with embedding.
If image is not inlined, it must not be displayed as an image, just as a
link. Your code will break this convention.
Please refer to "13.9.9 Images in HTML export" section of Org manual.
>> But the original code is different, no?
>
> Yes, I pretend that my code is an improvement:
> 1. The with-syntax-table is superfluous.
> 2. The error message gives a reason and the filename causing it.
Then, I find your code sufficiently different to not link to
stackoverflow. This link is not helpful to understand the code.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2023-06-07 9:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 13:23 [PATCH] ox-html.el: add option to embed SVG for CSS support in SVG gerard.vermeulen
2023-06-06 7:49 ` Ihor Radchenko
2023-06-06 9:57 ` Christian Moe
2023-06-06 13:37 ` gerard.vermeulen
2023-06-06 18:54 ` Christian Moe
2023-06-07 8:43 ` Ihor Radchenko
2023-06-07 8:41 ` Ihor Radchenko
2023-06-07 14:30 ` Christian Moe
2023-06-07 17:57 ` Ihor Radchenko
2023-06-15 13:09 ` gerard.vermeulen
2023-06-15 14:55 ` Max Nikulin
2023-06-15 20:42 ` Ihor Radchenko
2023-06-15 20:51 ` Ihor Radchenko
2023-06-16 18:39 ` gerard.vermeulen
2023-06-17 12:38 ` Ihor Radchenko
2023-06-17 14:45 ` gerard.vermeulen
2023-06-21 15:52 ` Max Nikulin
2023-06-21 16:02 ` Ihor Radchenko
2023-06-21 16:27 ` Max Nikulin
2023-06-21 16:38 ` Ihor Radchenko
2023-06-22 16:25 ` Max Nikulin
2023-06-23 11:02 ` Ihor Radchenko
2023-06-06 12:58 ` gerard.vermeulen
2023-06-07 9:07 ` Ihor Radchenko [this message]
2023-06-06 14:14 ` Max Nikulin
2023-06-06 16:08 ` gerard.vermeulen
2023-06-07 9:10 ` Ihor Radchenko
2023-06-09 15:27 ` Max Nikulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877csfej3a.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=gerard.vermeulen@posteo.net \
--cc=mail@christianmoe.com \
--cc=orgmode@tec.tecosaur.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).