Re: Worg: issue with org-tools page

[Ihor Radchenko <yantar92@posteo.net>]

[-- Attachment #1: Type: text/plain, Size: 974 bytes --]

Karl Voit <devnull@Karl-Voit.at> writes:

>> I believe that I fixed the issue in
>> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=4929f0c55f
>>
>> But I am not sure if I actually did. We need to trigger WORG rebuild to
>> see, I think.
>
> I just committed a minimal change to that file which caused the CI
> to re-build the page: https://builds.sr.ht/~bzg/job/975519 which
> ended successfully but still shows an error:

I suspect that there is some misconfiguration of the build.
But before we go into this, let's first address the problem with
publishing being silent when some files fail to be exported.
We cannot even notice the failures now unless we check changes manually!
WORG build thinks that publishing is "success" and does not trigger
failure email.

I am attaching tentative patch that will revert demoting errors to
messages. However, I do not fully understand the purpose of the original
`condition-case' code in the publish.sh. Bastien?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-publish.sh-Trigger-error-when-any-file-fails-to-expo.patch --]
[-- Type: text/x-patch, Size: 1011 bytes --]

From 1a26aa06f1504d7c9da650c83964351f3cc61715 Mon Sep 17 00:00:00 2001
Message-ID: <1a26aa06f1504d7c9da650c83964351f3cc61715.1690632604.git.yantar92@posteo.net>
From: Ihor Radchenko <yantar92@posteo.net>
Date: Sat, 29 Jul 2023 15:08:59 +0300
Subject: [PATCH] * publish.sh: Trigger error when any file fails to export

If we do not throw an error, it may go unnoticed and will not trigger
CI report.

Link: https://orgmode.org/list/2023-04-18T15-32-06@devnull.Karl-Voit.at
---
 publish.sh | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/publish.sh b/publish.sh
index fd931893..71c3a175 100755
--- a/publish.sh
+++ b/publish.sh
@@ -53,6 +53,4 @@
 	(message " [skipping] unchanged %s" org-file)
       (message "[exporting] %s" (file-relative-name org-file default-directory))
       (with-current-buffer (find-file org-file)
-	(condition-case err
-	    (org-html-export-to-html)
-          (error (message (error-message-string err))))))))
+       (org-html-export-to-html)))))
-- 
2.41.0


[-- Attachment #3: Type: text/plain, Size: 224 bytes --]


-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>