From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 0Jg3GXOS3GQMigAASxT56A (envelope-from ) for ; Wed, 16 Aug 2023 11:10:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id MFQxGHOS3GTxZAAAG6o9tA (envelope-from ) for ; Wed, 16 Aug 2023 11:10:11 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CC2624F37F for ; Wed, 16 Aug 2023 11:10:05 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Rc6DPVQ5; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1692177006; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=4Na91LrtHGp3FJbN+pIE8LJqRWcSyYwsPA4A/ieco28=; b=X1M7fjfDk84c+CLUJIlMUpOBpve+My9eq1/HeaKhxoMCjV3s7M+2HxpuqNFYylgTASo4bJ Sb3cTOR2jwyhXD0fv6gbQUn4k7rRVALOhj/etzVAn9wkYNnp797OtI8T02QtcCxrbm5bmt ddP8IuBiR+h/qpB2mLyBvtA+UflKlpklNgC9ThcqtoXwTSaLzk2nGpZD0K5UlK8c4mYBsL KD27gYZ6ivL45NnZyjLyWcVryfFpKKbKjAbjmq14UqZ9vbuwHJ62kta4IMnNulXPEd/8Sm Z1PZ791IIQdD1HNFBfBdEIqv7S37mE/3BdgHhglQDyVXXWX+Se7aFWoGsXcApw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Rc6DPVQ5; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1692177006; a=rsa-sha256; cv=none; b=nCEXDtw+duWQP3cFih6Cg2qxdipjYIJ+thBv0cshs8xpgwTnutG47MDnnK5RvwZ9AGk3+D vcw3YOJQYRqfkmhZjkWZy/jP1LUJTBYqqAzJFC6Q4R+GcIgfz8rmPxgxA/KbCCcscFJsLs cw0IwaOGoxjipt6cS6gmV8EqJ68iFBvxhpfhiDxPbNiILGDiqAAcbxKQjO6njyzudjAIrP 0fBBUDw/jGjbO6egQpML0ijCKHAPvzy9oWGoVM22uqheS0iz/OPhPTkF/rvwPVWILzNs2E ARopoE/PRWAqgNQ+QjJVbL6M8Fm6HPFoLj0x9mNz91dSRou3+90GgYVh+OdhYA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qWCWe-0008Fg-IW; Wed, 16 Aug 2023 05:09:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWCWd-0008FU-0I for emacs-orgmode@gnu.org; Wed, 16 Aug 2023 05:09:11 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWCWa-0004kh-4l for emacs-orgmode@gnu.org; Wed, 16 Aug 2023 05:09:10 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 088D124002A for ; Wed, 16 Aug 2023 11:09:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1692176946; bh=4ZRvgczu/hkpJIFchrCOHsH4TJnl4Apo9zsi654zHo8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=Rc6DPVQ5DH6zqS9QlpCWvbjas+Ooh0U1fJhNQBcv49awZ26J1G6dbdTnkkw3n6may jWF3WgfQthuM6PgozTPIZ3SC3k8jcMhocGh7qNAFVMhX4AChitGvukU4DCJNsQ7FSp 54UZ0LgqS2luod+oPz1iMiZiyTrrqBuLPE3j7ne3/hjYHjId1l/cD2j9Tk1B3sdNJL bj6C3YGhmONmDtCZSq0Azrl7qy/AHmUE/5JOFeM+RcNWGSnVQe819Qet4W5uZ1STls 8cyM/R7A69c2ZrluwbgOvCIOhLc/7nMGB9iup1SE3Lhdjxh8dJNLD7ct/eazGpMZ0F UIpfhp9NCcrcQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RQj4K3D10z6tvr; Wed, 16 Aug 2023 11:09:05 +0200 (CEST) From: Ihor Radchenko To: Tom Gillespie Cc: emacs-orgmode Subject: Re: [PATCH] ob-tangle.el: restore :tangle closure nil behavior In-Reply-To: References: Date: Wed, 16 Aug 2023 09:09:33 +0000 Message-ID: <877cpvpd4i.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: -6.76 X-Migadu-Queue-Id: CC2624F37F X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -6.76 X-TUID: Ot+S7jotvB+c Tom Gillespie writes: > Subject: [PATCH] ob-tangle.el: restore :tangle closure evaluation before eval > info > This patch fixes a bug where header arguments like :tangle (or "no") > were treated as if they were tangling to a file named "(or \"no\")". > As a result, org-bable would call org-babel-get-src-block-info with > 'no-eval set to nil, causing parameters to be evaluated despite the > fact that when :tangle no or equivalent is set, the other parameters > should never be evaluated. What do you mean by "restore"? Were it evaluated in the past? May you please provide a reproducer? > -(defun org-babel-tangle--unbracketed-link (params) > +(defun org-babel-tangle--unbracketed-link (params &optional info-was-evaled) This is not acceptable. Taking care about evaluating INFO should be done in a single place instead of adding checks across the babel code. If we go the proposed way, I expect a number of bugs appearing when somebody forgets to change the eval check in some place. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at