From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id MIG7H6WocWZWpwAAqHPOHw:P1 (envelope-from ) for ; Tue, 18 Jun 2024 15:32:53 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id MIG7H6WocWZWpwAAqHPOHw (envelope-from ) for ; Tue, 18 Jun 2024 17:32:53 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=SHOeoc1Z; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1718724773; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=jGkxTtJPC7OLWVjzA0gv7r0tPnPuWoM9zRrYVri23Gg=; b=Z78Pyo1GErdyYN+2zTCsWlLPNu99XNepL11LTi0lH5Lk7aRdC3dOCESvTObKehHtbGo7PH PypdQ+q+EleDGTtvJxU6jo+8TSIkApz6HmXM/1KNLHxrhrwAuIqdQ2YZpSLLjrjhuViUQj MVa/P5qy+nAm/Ntb8w5kTaC1t1BDRTQIp8pi1WHGB5nQmXBtVS+ki5tuR9KkHHvRjnvCQa k+Dqv5m7IREhcB6vfIPdnW5RkAF7HGgSvFHVcIhoNLbqsORSUYmuAATRcE8Hu9EYJ5dpDq 3V0YQd10+xu65fDFRJviLgsGxLd6x3JTHIwc3Vn/+WnmrDbFT6AdGY9QktUcmQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=SHOeoc1Z; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1718724773; a=rsa-sha256; cv=none; b=MHvuZyQc3kOKPYd6+fX7zFXV0OeCljWKBqSHVx/xRMSbaLfZy25y4zV2/hzDwO3Hm9aKoS o8Cs0+Iz9iTTud8TLusZC6pp6bYOialbuDTMZaViwEqE+gp/zVQVxlWhRtlUOyfk9RrN5p ahC1Mn4jd6LfrVlX+JwCpCM8FeRh64RHkUThqnHxVMPIejtU2/nPAhZDJNAkV6qTGATCmu Nb3YUpSJen7G1dCuo0HNnapDyNoSmpwX5zYFGyBErHiGMkmLMuJJMnACRAO34nH8MkIGYv jP6g2a+dJ4K0+0uyTq5/s23zcF1wUPxHQnrVLaC7InWjIXWIbl5swCrsw+HNfg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0F99620781 for ; Tue, 18 Jun 2024 17:32:53 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJaoZ-0003Ah-Ti; Tue, 18 Jun 2024 11:32:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJaoY-0003AO-3U for emacs-orgmode@gnu.org; Tue, 18 Jun 2024 11:32:06 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJaoV-0001nG-GB for emacs-orgmode@gnu.org; Tue, 18 Jun 2024 11:32:05 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id C81E6240029 for ; Tue, 18 Jun 2024 17:31:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1718724719; bh=Twk0uk9sHR15Ww1i5upYS6rQHIs2+AdFr+lDSImcfE8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=SHOeoc1Z3vCDngI1w1ngn5mYMSg1HBT/oiABeRRYTuHrRRXiWTXb58sAKF9SD2ORR gI3yq43YHNJItcZZsqlt+hDvHQjEgyUH760ihOMpKdPnFNCkDSpdcYoLLpYCvY6FQs uTSoIKDxOEt5uz5cVsavsK/94FYOcTHnpB72ni+k36ojsN488+WmScg+bhk6W/0J23 1qBrLKcr7ZFuXcTFdiRLR9uuaSOAja582Ye1XkB1TKoS7bKBMxuZzxhwmagX7yO39Z 70stWi5+B3a3EdtV2LQzSG9kvv5TqxRe771ty1VOrW/I4oNYDZL5QKJYVl2FBrFEd4 4MAjjCm4sZp7w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4W3W2Q5b5zz9rxR; Tue, 18 Jun 2024 17:31:58 +0200 (CEST) From: Ihor Radchenko To: Suhail Singh , TEC Cc: Org mailing list Subject: Re: [PATCH] [BUG] Support attr_html in source code and fixed-width blocks In-Reply-To: <87v8277ye7.fsf@gmail.com> References: <87v8277ye7.fsf@gmail.com> Date: Tue, 18 Jun 2024 15:33:43 +0000 Message-ID: <877cems1t4.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -6.58 X-Migadu-Queue-Id: 0F99620781 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -6.58 X-TUID: qVR8Y7Lt0RC1 Suhail Singh writes: > Unlike example blocks, source code and fixed-width blocks don't support > the attr_html keyword. Contrast these outputs: > ... > The attached patches are a straight-forward copy-paste of relevant code > from org-html-example-block. It may be better to refactor this logic > and ensure that it is applied on all relevant AST nodes (others are > probably affected as well). Sounds reasonable. Timothy, may you have a look? I am not sure if we want to add all the attributes to every transcoded element. At least in some cases, we do discard them (`org-html--textarea-block'). -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at