From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id qEhHIqOunmYWzgAAqHPOHw:P1 (envelope-from ) for ; Mon, 22 Jul 2024 19:10:27 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id qEhHIqOunmYWzgAAqHPOHw (envelope-from ) for ; Mon, 22 Jul 2024 21:10:27 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=AGKGaryp; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1721675427; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Z0y0NCS3aJkR9bMOl1tdwvef0SeUUZQD5sbg6nCvXuE=; b=OA7KSxdrjtS69lMt04Pq+mcOtIla9XiFWzVNBspK0W1D+ShVH+sl11hUbw6h6XcMWCAKE1 FBL/JKvnweRmW3eUKlo+T+ghjIHKxuCsUQfV0iXybfBTETxHw4cd1xT8EXzH/ngOrEbQcg 6dHgR0618QVUzci2tjloxoBJOf/LHM5Vo7HleT3H52DIpEFlgaJRitaiH5TwIs/pgDUH7d uVPwmQSxZPiU1Um2oj29uJzFHYdxJ/044wrJzW8H6jH/aqPf/Pzw31Leesi1FPO7dhd29F KFuIkn0gPCWsbZs2qKyB5r3JKgr1cfba4gwbLXykxIbR5OA4TF3dPMVy3Ub69A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1721675427; a=rsa-sha256; cv=none; b=h9RnWKI0qpEpqVoAvt1aJWh3eeX7NFZ9PYUbOubnZf5mQXPohTxXy+bfYBADBBvZTbCUFO 7O7MAO0rqBuZJpt8zOfrXwFqzIIpaOBmMq71LxtYazEDd9FE4AVdcREeRYy71KXVnsMQ0q Nbvp+nkU3Qzo2HCfL0/BUUqbqWBZb8AKIWTA3zc07QjVS0Ne+4AVWyfqyVK87rUKGZvXAe OuxEU6xeCQvK32otMoymb3niKhARqRWtc5HtzOz0MkmB3Ma0Goz/gkRDm3+viuil/wly+e 8p+zzV3lKbp8HihN2ycIRat82Ap4ltVSMPtZQmbFnIAIEwPJaPE9JRrXLt/ofA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=AGKGaryp; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0BEDA65D1B for ; Mon, 22 Jul 2024 21:10:27 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sVyPd-0001K2-DC; Mon, 22 Jul 2024 15:09:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sVyPb-0001JT-Ho for emacs-orgmode@gnu.org; Mon, 22 Jul 2024 15:09:31 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sVyPZ-0008TL-4z for emacs-orgmode@gnu.org; Mon, 22 Jul 2024 15:09:31 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 74356240028 for ; Mon, 22 Jul 2024 21:09:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1721675365; bh=9TlVDZaAOYq8o5+Rnje7gJ1oJrw5o2k1OjiP4Ob0Pkw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=AGKGarypVeulBvNFHH6qvY8AFxhszJ+NK78Eghe7oxJ0gYgrH02ikQGzJDoloPQ+W bwLiAVLmNHVXuglwtp67KtaUXwJM4USgviQrF5UBglauNarQCOiLFh20azJY3dZ0TM uDASpyora2P4+6WXIvHjde2rWxO5OQqHWNvtugINsdAn8tA8t75n3kqBcPUqHgni0X Sz4vkPQ7Tb+tgy6llFGDKPQTNUhATUi5qSApA9MU9Gt7Y/X4lJseqEEBFqA+3zIZbl 0po9MHg14G87YllWkVIsMtCPkPCF7mumCyKRM3Ej6VbDFGLhA4rVfhPVlHytoEZRLA LX462SrGQIKwA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4WSVFb0Nq9z9rxW; Mon, 22 Jul 2024 21:09:22 +0200 (CEST) From: Ihor Radchenko To: Suhail Singh Cc: TEC , Org mailing list Subject: Re: [PATCH] [BUG] Support attr_html in source code and fixed-width blocks In-Reply-To: <87cyn52rm5.fsf@gmail.com> References: <87v8277ye7.fsf@gmail.com> <877cems1t4.fsf@localhost> <8734o5v1sg.fsf@gmail.com> <87le1tmt8w.fsf@localhost> <87r0bl2vyv.fsf@gmail.com> <87a5i9mh19.fsf@localhost> <87cyn52rm5.fsf@gmail.com> Date: Mon, 22 Jul 2024 19:10:51 +0000 Message-ID: <877cddmedg.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 0BEDA65D1B X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -9.64 X-Spam-Score: -9.64 X-TUID: SgXwqejcFSpw Suhail Singh writes: >> So, if we start allowing arbitrary attributes in more blocks, may as >> well include specially handled attributes like :textarea. > > Yes, it is possible to address my concern while also extending support > for non-HTML attributes like :textarea. However, they still are > distinct things. For instance, it's possible that extending support for > :textarea is considered a feature request (as opposed to a bug), and > thus that support is added to the main branch as opposed to bugfix. FYI, regardless how we categorize this (bug or feature), it is not for bugfix because we are changing the existing behavior. Some users might have #+ATTR_HTML being present and ignored. Not ignoring them, even if it is a bug fix, is not acceptable for bugfix branch - it is not a _trivial_ bug fix. So, it has to go on main. >> Since we do not promise it anywhere, it is not necessarily a bug. > > We also don't, as far as I am aware, mention that support for > #+ATTR_HTML is ONLY available for some AST nodes and NOT others. Given > that for the treatment of :textarea we are very clear on this point, the > fact that we don't for #+ATTR_HTML suggested to me that this was a bug. > I suppose it's debatable, however, whether it's a bug in the > documentation or the code. But, given most (all?) HTML elements support > attributes, it would be odd if the intent of ox-html was to provide a > way to support it via #+ATTR_HTML while simultaneously /intentionally/ > restricting its use to only a few nodes. Since `:textarea' is a "custom" > attribute with special signifance, it makes sense that support for it > may be limited in scope. > > Do you still consider this to be a feature request instead of a bug? AFAIU, your main point is that you want the patch to land on bugfix. It will not, regardless whether we add :textarea support or not. Next, if you are not interested in adding :textarea support, it is OK. Adding #+ATTR_HTML support for code blocks and fixed width elements will still be a welcome improvement (I was just hoping to push you to contribute a bit more ;)) Now, back to your original patch. May you please factor out adding attributes into a separate function, so that we avoid duplicating the code? And please announce the change in the news - people aware of the current behavior might need to know about the change. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at