From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 6EgsFqqTamczmQAAe85BDQ:P1 (envelope-from ) for ; Tue, 24 Dec 2024 10:57:46 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 6EgsFqqTamczmQAAe85BDQ (envelope-from ) for ; Tue, 24 Dec 2024 11:57:46 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=alM1JOyx; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1735037865; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=bxeBa5ko9EcTWeojiuORKj+eneZTwAymcDyaDaoN/aQ=; b=XBaPmEm2H1y+Y4/xVpBbIo92+XMS2z6sGhp9fDN1IKUk9TjXx3JF0HPxa2VZVN18WtzPMz 8+skm0EAcMFkoIh+/yf1jhzuPPRhHbThYKAfQRfdGNS4YGgxvMuhjk7AVv8UoGmXhE4qg5 7VHxWRLWzd8w+OIT+sQJbe/QZ2LONWxedzY4A6H/QYhUoGEQHrPQg//7VUJ78rdrgY4JRA dHqFUpVNz0oi5Ytv+eRpSnTa0tTJhgdmQ2upKBPLpmDJQh4wD8b0HQEkTN8lpzZa5ti0yn +HcZFC8F2E/sd554nByZBhYirGge1S3qj7yDRsmi3eqmUcUrMJyiiidESuK3zg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=alM1JOyx; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1735037865; a=rsa-sha256; cv=none; b=gDcHxxqTxpQ9Y6gEGNl+wiJYYz5T8BUYrhLmdy9G7Af24OVja6xBO4plBQBvbl94ldX4z+ oW9NSuVOvdbeqsdEdH7ofN+ffS8ITQxKIeALRke3DSddkznZX8QOLvPDgRN6pLEkXq3NnF UiHhDeHeftxPNIJvlwjZr77mZxWshQgYfn0v5w01v12GhAoPof8UOBqNXH0h0A8sqjX8Ln 2wOSF+edqli3dBf5ePxi/lbq3xctdzD70pydCtB1cRgblbxZnwCjD5I5xhtWI3otIKaFkd BxQ3JuxKn7pgytlQuUHP/4KPKo9YL86Qb9VchcFskGjOv8zVEi7RL0kBBJAanQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 50E1823375 for ; Tue, 24 Dec 2024 11:57:45 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tQ2at-000607-Fo; Tue, 24 Dec 2024 05:56:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQ2ao-0005zq-Sy for emacs-orgmode@gnu.org; Tue, 24 Dec 2024 05:56:52 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQ2ak-0001td-BE for emacs-orgmode@gnu.org; Tue, 24 Dec 2024 05:56:49 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 6C12824010B for ; Tue, 24 Dec 2024 11:56:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1735037801; bh=DJWT8l1S/7k5BziNhBSg+bap8GEEt9u3jUIrtVHL220=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=alM1JOyxuNZ4PuI6esohnW1I4hWmQ0BlO+KgZXqTwRbvTrnvTosxn5JLFmYSxR1aD mV8wZ8LpCh4QW6jTDjGulypc3p1tD2Mo+8l0XRKkLQb8ZP2asBZwzU5nib4wQ1Jnb0 9BcUl9ZY5l9ef19sg/0gBHZW79EpFOCMxf4QT8yzHmVNeDDeES+OPyi38/uAwibXbj zRXJ31laUWB9HoaIdXtam1aJNaLymlR8R9SlOTLk92QMHZmP8EcZRHh7k5oZE6Z7Vz A+08tgCIM4XtK8FOLqm5W1KxIzPcFEIH8JlQuYLe5MVKppDygzrxhNm4YNCn/YuEqT Pmlmaxy+JXDbQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YHWzX5hQyz6txv; Tue, 24 Dec 2024 11:56:40 +0100 (CET) From: Ihor Radchenko To: Visuwesh Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] ob-calc: Format vector and matrix results as Org table In-Reply-To: <878qsj1kjl.fsf@gmail.com> References: <878qsj1kjl.fsf@gmail.com> Date: Tue, 24 Dec 2024 10:58:12 +0000 Message-ID: <877c7pibzv.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -4.48 X-Spam-Score: -4.48 X-Migadu-Queue-Id: 50E1823375 X-TUID: 5KCJGh2T3vdQ Visuwesh writes: > Attached patch formats vector and matrix results from a Calc source > block as Org table. To test, try > ... > now. The patch passes the old tests, and I added three new tests to > check the correctness of this conversion. Thanks! etc/ORG-NEWS entry seems to be displaced. It should be under Org 9.8 heading. Also, the patch does not apply onto the latest main. > -#+BEGIN_SRC calc :results silent :var a=ob-calc-table-1 > +#+BEGIN_SRC calc :results silent verbatim :var a=ob-calc-table-1 You had to change the tests, so we have a breaking change. The change can be viewed as a bug fix since ob-calc previously did not conform to babel conventions, so I do not object changing the defaults. However, we need to inform the affected users and put the announcement into "breaking changes" section. We should also recommend changing org-babel-default-header-args:calc to restore the old behavior. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at . Support Org development at , or support my work at